Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GROOVY-11563: STC: check compound assignment x op= y like x = x op y #2148

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eric-milles
Copy link
Member

@eric-milles eric-milles commented Feb 2, 2025

This is a work-in-progress to visit the implied binary expression from a compound assignment to get type-checking similar to the explicit long form. The GROOVY-10628 elvis assignment special-case approach is extended and moved up a bit earlier.

There are still several test case failures to investigate and deal with.

@asfgit asfgit force-pushed the GROOVY-11563 branch 4 times, most recently from 010c8a8 to 18c00c1 Compare February 2, 2025 20:26
@codecov-commenter
Copy link

codecov-commenter commented Feb 2, 2025

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.8288%. Comparing base (6dff05e) to head (7ba1012).

Files with missing lines Patch % Lines
src/main/groovy/groovy/grape/GrapeIvy.groovy 50.0000% 1 Missing ⚠️
...ovy/classgen/asm/sc/StaticTypesCallSiteWriter.java 0.0000% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                 @@
##               master      #2148        +/-   ##
==================================================
+ Coverage     68.8286%   68.8288%   +0.0002%     
+ Complexity      29443      29441         -2     
==================================================
  Files            1420       1420                
  Lines          113168     113188        +20     
  Branches        19550      19555         +5     
==================================================
+ Hits            77892      77906        +14     
- Misses          28737      28738         +1     
- Partials         6539       6544         +5     
Files with missing lines Coverage Δ
...roovy/transform/stc/StaticTypeCheckingVisitor.java 87.6373% <100.0000%> (-0.0433%) ⬇️
src/main/groovy/groovy/grape/GrapeIvy.groovy 39.1429% <50.0000%> (ø)
...ovy/classgen/asm/sc/StaticTypesCallSiteWriter.java 74.0125% <0.0000%> (ø)

... and 7 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants