fix(sunburst): label rotation flipping #19176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarts-bot
bot
added
PR: author is committer
PR: awaiting review
PR: doc unchanged
labels
|
Thanks for your contribution! The pull request is marked to be |
|
The changes brought by this PR can be previewed at: https://echarts.apache.org/examples/editor?version=PR-19176@d9e67dd |
|
Congratulations! Your PR has been merged. Thanks for your contribution! 👍 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Many cases were reported with sunburst's label rotation and several PRs trying to fix them have been merged (#18240, #18962, #19174). This PR refactored and simplified the related code, fixes the problem of #19127 and tested all reported cases and make sure the label rotation algorithm is as robust as possible.
Fixed issues
Details
Before: What was the problem?
Label align is not syncing with rotation flipping, so the text is at the wrong position.
After: How does it behave after the fixing?
Use
needsFlipto make sure this logic is the same with align and rotation.Diff:
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
I've run the visual test with the last version 5.4.3 and the result is as expected. I've also tested all rotation values and clockwise values to make sure the text is always in the readable direction.
Others
Merging options
Other information