Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(graph): fix graph chart can't be hidden by legend due to edgeLabel NPE #18624

Merged
merged 2 commits into from
May 15, 2023

Conversation

plainheart
Copy link
Member

Brief Information

This pull request is in the type of:

  • bug fixing
  • new feature
  • others

What does this PR do?

Fix graph chart can't be hidden by legend due to edgeLabel NPE.

Fixed issues

Resolves #18614

Details

Before: What was the problem?

The graph chart can't be hidden by legend and throw an NPE

image

After: How does it behave after the fixing?

The SeriesData#cloneShallow will exclude the visual and layout properties, so the visualStyle may be undefined.

const visualStyle = data.getItemVisual(dataIndex, 'style');

Here I try to add a guard to avoid NPE.

image

Document Info

One of the following should be checked.

  • This PR doesn't relate to document changes
  • The document should be updated later
  • The document changes have been made in apache/echarts-doc#xxx

Misc

ZRender Changes

  • [] This PR depends on ZRender changes (ecomfe/zrender#xxx).

Related test cases or examples to use the new APIs

Please refer to the second test case in test/graph-case.html.

Others

Merging options

  • Please squash the commits into a single one when merging.

Other information

BTW, I enabled eslint cache to speed up the check.

@echarts-bot
Copy link

echarts-bot bot commented May 14, 2023

Thanks for your contribution!
The community will review it ASAP. In the meanwhile, please checkout the coding standard and Wiki about How to make a pull request.

The pull request is marked to be PR: author is committer because you are a committer of this project.

@plainheart plainheart added this to the 5.5.0 milestone May 14, 2023
@plainheart plainheart merged commit daa7479 into master May 15, 2023
@echarts-bot
Copy link

echarts-bot bot commented May 15, 2023

Congratulations! Your PR has been merged. Thanks for your contribution! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Legend hide/show error with graph edgeLabel on geo map
2 participants