fix(graph): fix graph chart can't be hidden by legend due to edgeLabel NPE #18624
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Brief Information
This pull request is in the type of:
What does this PR do?
Fix graph chart can't be hidden by legend due to edgeLabel NPE.
Fixed issues
Resolves #18614
Details
Before: What was the problem?
The graph chart can't be hidden by legend and throw an NPE
After: How does it behave after the fixing?
The
SeriesData#cloneShallow
will exclude the visual and layout properties, so thevisualStyle
may be undefined.echarts/src/label/LabelManager.ts
Line 489 in dfd95aa
Here I try to add a guard to avoid NPE.
Document Info
One of the following should be checked.
Misc
ZRender Changes
Related test cases or examples to use the new APIs
Please refer to the second test case in
test/graph-case.html
.Others
Merging options
Other information
BTW, I enabled eslint cache to speed up the check.