Merge pull request #18624 from apache/fix/graph/edgeLabel-NPE

fix(graph): fix graph chart can't be hidden by legend due to edgeLabel NPE
apache · May 15, 2023 · daa7479 · daa7479
2 parents 9e5745a + dfd95aa
commit daa7479
Show file tree

Hide file tree

Showing 5 changed files with 69 additions and 7 deletions.
diff --git a/package.json b/package.json
@@ -58,7 +58,7 @@
     "mktest": "node test/build/mktest.js",
     "mktest:help": "node test/build/mktest.js -h",
     "checktype": "tsc --noEmit",
-    "lint": "npx eslint src/**/*.ts extension-src/**/*.ts",
+    "lint": "npx eslint --cache --cache-location node_modules/.cache/eslint src/**/*.ts extension-src/**/*.ts",
     "lint:fix": "npx eslint --fix src/**/*.ts extension-src/**/*.ts",
     "lint:dist": "echo 'It might take a while. Please wait ...' && npx jshint --config .jshintrc-dist dist/echarts.js"
   },

diff --git a/src/label/LabelManager.ts b/src/label/LabelManager.ts
@@ -487,10 +487,11 @@ class LabelManager {
 
             const defaultStyle: PathStyleProps = {};
             const visualStyle = data.getItemVisual(dataIndex, 'style');
-            const visualType = data.getVisual('drawType');
-            // Default to be same with main color
-            defaultStyle.stroke = visualStyle[visualType];
-
+            if (visualStyle) {
+                const visualType = data.getVisual('drawType');
+                // Default to be same with main color
+                defaultStyle.stroke = visualStyle[visualType];
+            }
             const labelLineModel = itemModel.getModel('labelLine');
 
             setLabelLineStyle(el, getLabelLineStatesModels(itemModel), defaultStyle);
@@ -591,4 +592,5 @@ class LabelManager {
 }
 
 
-export default LabelManager;
+export default LabelManager;
+
diff --git a/test/graph-case.html b/test/graph-case.html
diff --git a/test/runTest/actions/__meta__.json b/test/runTest/actions/__meta__.json
diff --git a/test/runTest/actions/graph-case.json b/test/runTest/actions/graph-case.json