-
Notifications
You must be signed in to change notification settings - Fork 934
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rest protocol #329
Rest protocol #329
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Firstly, it seems that we use the camel case rather than xxx_xxx
Codecov Report
@@ Coverage Diff @@
## feature/rest #329 +/- ##
================================================
+ Coverage 66.32% 66.78% +0.46%
================================================
Files 127 128 +1
Lines 7828 7877 +49
================================================
+ Hits 5192 5261 +69
+ Misses 2130 2098 -32
- Partials 506 518 +12
Continue to review full report at Codecov.
|
logger.Infof("[Go Restful] Server exiting") | ||
} | ||
|
||
func getArgsFromRequest(req *restful.Request, types []reflect.Type, config *rest_interface.RestMethodConfig) []interface{} { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you split this method into several smaller methods?
What this PR does:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: