Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix : zk problem #346

Merged
merged 3 commits into from
Feb 2, 2020
Merged

Fix : zk problem #346

merged 3 commits into from
Feb 2, 2020

Conversation

pantianying
Copy link
Member

What this PR does:
1.exit listen when zk.errNilNode happen
2.Ftr the lock of ZookeeperClient
Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

codecov-io commented Jan 31, 2020

Codecov Report

Merging #346 into develop will decrease coverage by 0.04%.
The diff coverage is 68.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #346      +/-   ##
===========================================
- Coverage    66.88%   66.83%   -0.05%     
===========================================
  Files          123      123              
  Lines         7597     7628      +31     
===========================================
+ Hits          5081     5098      +17     
- Misses        2024     2036      +12     
- Partials       492      494       +2
Impacted Files Coverage Δ
remoting/zookeeper/listener.go 52.02% <0%> (-1.24%) ⬇️
remoting/zookeeper/client.go 68.06% <76.47%> (+0.14%) ⬆️
protocol/dubbo/dubbo_invoker.go 89.36% <0%> (-2.95%) ⬇️
protocol/dubbo/pool.go 80% <0%> (-2.33%) ⬇️
protocol/dubbo/listener.go 63.24% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4de49ef...cb9cc37. Read the comment docs.

Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@flycash flycash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@flycash flycash merged commit d654f3a into apache:develop Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants