[refine](bits) refine bytes_mask_to_bits_mask code (#38360) #43511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous code only considered the x86 architecture, and _mm_movemask_epi8 does not have a corresponding instruction in ARM. According to the article below, we need to abstract the overall logic. For ARM, optimize using the content mentioned in the following article: filter function origin 0.711375 seconds 0.7154 seconds 0.71782 seconds 0.715296 seconds filter function arm opt 0.559854 seconds 0.559854 seconds 0.559854 seconds 0.559854 seconds [link](https://community.arm.com/arm-community-blogs/b/infrastructure-solutions-blog/posts/porting-x86-vector-bitmask-optimizations-to-arm-neon?CommentId=af187ac6-ae00-4e4d-bbf0-e142187aa92e)
|
Thank you for your contribution to Apache Doris. Please clearly describe your PR:
|
|
run buildall |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #if defined(__ARM_NEON) && defined(__aarch64__) | ||
| #include <arm_neon.h> | ||
| #endif | ||
|
|
||
| #include "util/sse_util.hpp" |
There was a problem hiding this comment.
warning: 'util/sse_util.hpp' file not found [clang-diagnostic-error]
#include "util/sse_util.hpp"
^
|
TeamCity be ut coverage result: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#38360
The previous code only considered the x86 architecture, and _mm_movemask_epi8 does not have a corresponding instruction in ARM. According to the article below, we need to abstract the overall logic. For ARM, optimize using the content mentioned in the following article: filter function origin 0.711375 seconds 0.7154 seconds 0.71782 seconds 0.715296 seconds
filter function arm opt 0.559854 seconds 0.559854 seconds 0.559854 seconds 0.559854 seconds
link
What problem does this PR solve?
Issue Number: close #xxx
Related PR: #xxx
Problem Summary:
Release note
None
Check List (For Author)
Test
Behavior changed:
Does this need documentation?
Check List (For Reviewer who merge this PR)