[refine](bits) refine bytes_mask_to_bits_mask code #38360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
|
run buildall |
|
clang-tidy review says "All clean, LGTM! 👍" |
TPC-H: Total hot run time: 40187 ms |
TPC-DS: Total hot run time: 172284 ms |
ClickBench: Total hot run time: 31.15 s |
|
run p0 |
|
run buildall |
TPC-H: Total hot run time: 39783 ms |
TPC-DS: Total hot run time: 171811 ms |
ClickBench: Total hot run time: 31.14 s |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #if defined(__ARM_NEON) && defined(__aarch64__) | ||
| #include <arm_neon.h> | ||
| #endif | ||
|
|
||
| #include "util/sse_util.hpp" |
There was a problem hiding this comment.
warning: 'util/sse_util.hpp' file not found [clang-diagnostic-error]
#include "util/sse_util.hpp"
^
|
run buildall |
TPC-H: Total hot run time: 42211 ms |
TPC-DS: Total hot run time: 169133 ms |
ClickBench: Total hot run time: 30.05 s |
|
run buildall |
TPC-H: Total hot run time: 41994 ms |
TPC-DS: Total hot run time: 170285 ms |
ClickBench: Total hot run time: 29.57 s |
|
run p1 |
HappenLee
reviewed
Jul 30, 2024
be/src/util/simd/bits.h
Outdated
| /// todo(zeno) Compile add avx512 parameter, modify it to bytes64_mask_to_bits64_mask | ||
| /// Transform 32-byte mask to 32-bit mask | ||
| inline uint32_t bytes32_mask_to_bits32_mask(const uint8_t* data) { | ||
| consteval inline auto bits_mask_length() { |
There was a problem hiding this comment.
no need add inline keyword
|
run buildall |
TPC-H: Total hot run time: 41610 ms |
TPC-DS: Total hot run time: 170398 ms |
ClickBench: Total hot run time: 29.75 s |
|
run buildall |
|
run buildall |
TPC-H: Total hot run time: 42257 ms |
TPC-DS: Total hot run time: 170670 ms |
ClickBench: Total hot run time: 30.42 s |
github-actions
bot
added
the
approved
|
PR approved by at least one committer and no changes requested. |
|
PR approved by anyone and no changes requested. |
dataroaring
pushed a commit
that referenced
this pull request
Aug 26, 2024
## Proposed changes The previous code only considered the x86 architecture, and _mm_movemask_epi8 does not have a corresponding instruction in ARM. According to the article below, we need to abstract the overall logic. For ARM, optimize using the content mentioned in the following article: filter function origin 0.711375 seconds 0.7154 seconds 0.71782 seconds 0.715296 seconds filter function arm opt 0.559854 seconds 0.559854 seconds 0.559854 seconds 0.559854 seconds [link](https://community.arm.com/arm-community-blogs/b/infrastructure-solutions-blog/posts/porting-x86-vector-bitmask-optimizations-to-arm-neon?CommentId=af187ac6-ae00-4e4d-bbf0-e142187aa92e)
Mryange
added a commit
to Mryange/doris
that referenced
this pull request
Nov 8, 2024
The previous code only considered the x86 architecture, and _mm_movemask_epi8 does not have a corresponding instruction in ARM. According to the article below, we need to abstract the overall logic. For ARM, optimize using the content mentioned in the following article: filter function origin 0.711375 seconds 0.7154 seconds 0.71782 seconds 0.715296 seconds filter function arm opt 0.559854 seconds 0.559854 seconds 0.559854 seconds 0.559854 seconds [link](https://community.arm.com/arm-community-blogs/b/infrastructure-solutions-blog/posts/porting-x86-vector-bitmask-optimizations-to-arm-neon?CommentId=af187ac6-ae00-4e4d-bbf0-e142187aa92e)
16 tasks
yiguolei
pushed a commit
that referenced
this pull request
Nov 10, 2024
#38360 The previous code only considered the x86 architecture, and _mm_movemask_epi8 does not have a corresponding instruction in ARM. According to the article below, we need to abstract the overall logic. For ARM, optimize using the content mentioned in the following article: filter function origin 0.711375 seconds 0.7154 seconds 0.71782 seconds 0.715296 seconds filter function arm opt 0.559854 seconds 0.559854 seconds 0.559854 seconds 0.559854 seconds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The previous code only considered the x86 architecture, and _mm_movemask_epi8 does not have a corresponding instruction in ARM. According to the article below, we need to abstract the overall logic.
For ARM, optimize using the content mentioned in the following article:
filter function origin 0.711375 seconds 0.7154 seconds 0.71782 seconds 0.715296 seconds
filter function arm opt 0.559854 seconds 0.559854 seconds 0.559854 seconds 0.559854 seconds
link