Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cherry-pick](branch-2.1) support decimal256 for parquet reader #42241

Merged
merged 2 commits into from
Oct 22, 2024

Conversation

suxiaogang223
Copy link
Contributor

Proposed changes

pick pr: #41526

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@suxiaogang223
Copy link
Contributor Author

run buildall

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@@ -20,6 +20,7 @@
#include <gen_cpp/parquet_types.h>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: 'gen_cpp/parquet_types.h' file not found [clang-diagnostic-error]

#include <gen_cpp/parquet_types.h>
         ^

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 36.03% (9357/25968)
Line Coverage: 27.59% (76847/278524)
Region Coverage: 26.40% (39502/149642)
Branch Coverage: 23.17% (20094/86708)
Coverage Report: http://coverage.selectdb-in.cc/coverage/34fa6ee1aac2e591e8eeaa039c55294a7b3b4e39_34fa6ee1aac2e591e8eeaa039c55294a7b3b4e39/report/index.html

@morningman morningman merged commit 38e529c into apache:branch-2.1 Oct 22, 2024
18 of 20 checks passed
@yiguolei yiguolei mentioned this pull request Nov 6, 2024
@suxiaogang223 suxiaogang223 deleted the parquet_decimal256_21 branch December 12, 2024 09:27
@yiguolei yiguolei mentioned this pull request Jan 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants