Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[enhance](parquet) support decimal256 for parquet reader #41526

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

suxiaogang223
Copy link
Contributor

Proposed changes

Implemented reading parqeut files with decimal256 type

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need regression test case for parquet decimal 256 and BE unit test for [bit_util.h]

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@suxiaogang223
Copy link
Contributor Author

run buildall

@doris-robot
Copy link

TeamCity be ut coverage result:
Function Coverage: 37.31% (9640/25836)
Line Coverage: 28.69% (79919/278607)
Region Coverage: 28.10% (41333/147069)
Branch Coverage: 24.73% (21056/85142)
Coverage Report: http://coverage.selectdb-in.cc/coverage/5beb621f57f9393fefeb608d668c9f0168bfda5b_5beb621f57f9393fefeb608d668c9f0168bfda5b/report/index.html

Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Oct 8, 2024
Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR approved by at least one committer and no changes requested.

Copy link
Contributor

github-actions bot commented Oct 8, 2024

PR approved by anyone and no changes requested.

@wm1581066 wm1581066 added dev/2.1.x usercase Important user case type label labels Oct 9, 2024
Copy link
Contributor

@morningman morningman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@morningman morningman merged commit 3c5a98e into apache:master Oct 9, 2024
25 of 30 checks passed
@suxiaogang223 suxiaogang223 deleted the support_decimal256 branch October 10, 2024 08:02
eldenmoon pushed a commit to eldenmoon/incubator-doris that referenced this pull request Oct 10, 2024
## Proposed changes
Implemented reading parqeut files with decimal256 type
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
## Proposed changes
Implemented reading parqeut files with decimal256 type
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
## Proposed changes
Implemented reading parqeut files with decimal256 type
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 16, 2024
## Proposed changes
Implemented reading parqeut files with decimal256 type
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 16, 2024
## Proposed changes
Implemented reading parqeut files with decimal256 type
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 17, 2024
morningman added a commit that referenced this pull request Oct 17, 2024
) (#41923)

## Proposed changes
pick prs:
#41506
#41526
#41683
#41816

---------

Co-authored-by: morningman <morningman@163.com>
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 22, 2024
## Proposed changes
Implemented reading parqeut files with decimal256 type
suxiaogang223 added a commit to suxiaogang223/doris that referenced this pull request Oct 22, 2024
Implemented reading parqeut files with decimal256 type
morningman pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. dev/2.1.7-merged dev/3.0.3-merged reviewed usercase Important user case type label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants