-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[enhance](parquet) support decimal256 for parquet reader #41526
Conversation
Thank you for your contribution to Apache Doris. Since 2024-03-18, the Document has been moved to doris-website. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need regression test case for parquet decimal 256 and BE unit test for [bit_util.h]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
run buildall |
TeamCity be ut coverage result: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
PR approved by at least one committer and no changes requested. |
PR approved by anyone and no changes requested. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
## Proposed changes Implemented reading parqeut files with decimal256 type
## Proposed changes Implemented reading parqeut files with decimal256 type
## Proposed changes Implemented reading parqeut files with decimal256 type
## Proposed changes Implemented reading parqeut files with decimal256 type
## Proposed changes Implemented reading parqeut files with decimal256 type
…che#41526)" This reverts commit 3ff7697.
## Proposed changes Implemented reading parqeut files with decimal256 type
Implemented reading parqeut files with decimal256 type
## Proposed changes pick pr: #41526
Proposed changes
Implemented reading parqeut files with decimal256 type