Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix](Nereids) fix fold constant by be return type mismatched (#39723)(#41164)(#41331)(#41546) #41838

Merged
merged 7 commits into from
Oct 18, 2024

Conversation

LiBinfeng-01
Copy link
Collaborator

@LiBinfeng-01 LiBinfeng-01 commented Oct 15, 2024

cherry-pick: #39723 #41164 #41331 #41546 because later problem is intro by prev one, so put them together
when using fold constant by be,
the return type of substring('123456',1, 3) would changed to be text, which we want it to be 3 remove windowframe in window expression to avoid folding constant on be

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@LiBinfeng-01
Copy link
Collaborator Author

run feut

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@LiBinfeng-01 LiBinfeng-01 changed the title [fix](Nereids) fix fold constant by be return type mismatched (#39723)(#41164) [fix](Nereids) fix fold constant by be return type mismatched (#39723)(#41164)(#41331) Oct 17, 2024
@LiBinfeng-01
Copy link
Collaborator Author

run buildall

1 similar comment
@LiBinfeng-01
Copy link
Collaborator Author

run buildall

LiBinfeng-01 and others added 4 commits October 17, 2024 22:12
…#39723)(apache#41164) (apache#41537)

cherry-pick: apache#39723 apache#41164 because later problem is intro by prev one,
so put them together
when using fold constant by be,
the return type of substring('123456',1, 3) would changed to be text,
which we want it to be 3 remove windowframe in window expression
to avoid folding constant on be
set var hint need to be enable to use before analyze, so it need to be
set when parsing sql
now it would set twice when parse and begin of analyze
@LiBinfeng-01 LiBinfeng-01 changed the title [fix](Nereids) fix fold constant by be return type mismatched (#39723)(#41164)(#41331) [fix](Nereids) fix fold constant by be return type mismatched (#39723)(#41164)(#41331)(#41546) Oct 17, 2024
@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

This reverts commit d54ad72.
@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@924060929 924060929 merged commit 8409f24 into apache:branch-2.1 Oct 18, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants