Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix](Nereids) fix fold const be return type #41164

Merged
merged 2 commits into from
Sep 27, 2024

Conversation

LiBinfeng-01
Copy link
Collaborator

remove windowframe in window expression to avoid folding constant on be

@doris-robot
Copy link

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR

Since 2024-03-18, the Document has been moved to doris-website.
See Doris Document.

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@LiBinfeng-01
Copy link
Collaborator Author

run buildall

1 similar comment
@LiBinfeng-01
Copy link
Collaborator Author

run buildall

@LiBinfeng-01
Copy link
Collaborator Author

run p0

1 similar comment
@LiBinfeng-01
Copy link
Collaborator Author

run p0

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Sep 25, 2024
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@englefly englefly merged commit 0ef9ecd into apache:master Sep 27, 2024
25 of 28 checks passed
LiBinfeng-01 added a commit to LiBinfeng-01/doris that referenced this pull request Oct 8, 2024
remove windowframe in window expression to avoid folding constant on be
dataroaring pushed a commit that referenced this pull request Oct 9, 2024
remove windowframe in window expression to avoid folding constant on be
cjj2010 pushed a commit to cjj2010/doris that referenced this pull request Oct 12, 2024
remove windowframe in window expression to avoid folding constant on be
amorynan pushed a commit to amorynan/doris that referenced this pull request Oct 12, 2024
remove windowframe in window expression to avoid folding constant on be
morrySnow pushed a commit that referenced this pull request Oct 14, 2024
…#41164) (#41537)

cherry-pick: #39723 #41164 because later problem is intro by prev one,
so put them together
when using fold constant by be,
the return type of substring('123456',1, 3) would changed to be text,
which we want it to be 3 remove windowframe in window expression
to avoid folding constant on be
LiBinfeng-01 added a commit to LiBinfeng-01/doris that referenced this pull request Oct 15, 2024
…#39723)(apache#41164) (apache#41537)

cherry-pick: apache#39723 apache#41164 because later problem is intro by prev one,
so put them together
when using fold constant by be,
the return type of substring('123456',1, 3) would changed to be text,
which we want it to be 3 remove windowframe in window expression
to avoid folding constant on be
LiBinfeng-01 added a commit to LiBinfeng-01/doris that referenced this pull request Oct 17, 2024
…#39723)(apache#41164) (apache#41537)

cherry-pick: apache#39723 apache#41164 because later problem is intro by prev one,
so put them together
when using fold constant by be,
the return type of substring('123456',1, 3) would changed to be text,
which we want it to be 3 remove windowframe in window expression
to avoid folding constant on be
924060929 pushed a commit that referenced this pull request Oct 18, 2024
…#41164)(#41331)(#41546) (#41838)

cherry-pick: #39723 #41164 #41331 #41546 because later problem is intro by prev one, so put them together
when using fold constant by be,
the return type of substring('123456',1, 3) would changed to be text, which we want it to be 3 remove windowframe in window expression to avoid folding constant on be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants