[fix](cache) fix that ShardedLRUCache may coredump when destructor was called #10995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch! |
|
PR approved by anyone and no changes requested. |
liaoxin01
force-pushed
the
fix_lru
branch
2 times, most recently
from
af45889 to
256376a
Compare
miswujian
pushed a commit
to miswujian/doris
that referenced
this pull request
Jul 28, 2022
whutpencil
pushed a commit
to whutpencil/incubator-doris
that referenced
this pull request
Jul 29, 2022
eldenmoon
pushed a commit
to eldenmoon/incubator-doris
that referenced
this pull request
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Issue Number: close #10991
Problem Summary:
delete _shardsin~ShardedLRUCachehas a competition withMetricRegistry::trigger_all_hooks.Checklist(Required)
Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...