[fix](cache) fix that ShardedLRUCache may coredump when destructor was called

liaoxin01 · liaoxin01 · commit cb7943d9bc45 · 2022-07-19T10:41:55.000+08:00
diff --git a/be/src/olap/lru_cache.cpp b/be/src/olap/lru_cache.cpp
@@ -462,14 +462,14 @@ ShardedLRUCache::ShardedLRUCache(const std::string& name, size_t total_capacity,
 }
 
 ShardedLRUCache::~ShardedLRUCache() {
+    _entity->deregister_hook(_name);
+    DorisMetrics::instance()->metric_registry()->deregister_entity(_entity);
     if (_shards) {
         for (int s = 0; s < _num_shards; s++) {
             delete _shards[s];
         }
         delete[] _shards;
     }
-    _entity->deregister_hook(_name);
-    DorisMetrics::instance()->metric_registry()->deregister_entity(_entity);
 }
 
 Cache::Handle* ShardedLRUCache::insert(const CacheKey& key, void* value, size_t charge,

Original file line number	Diff line number	Diff line change
`@@ -462,14 +462,14 @@ ShardedLRUCache::ShardedLRUCache(const std::string& name, size_t total_capacity,`
`462`	`462`	`}`
`463`	`463`
`464`	`464`	`ShardedLRUCache::~ShardedLRUCache() {`
	`465`	`+ _entity->deregister_hook(_name);`
	`466`	`+ DorisMetrics::instance()->metric_registry()->deregister_entity(_entity);`
`465`	`467`	`if (_shards) {`
`466`	`468`	`for (int s = 0; s < _num_shards; s++) {`
`467`	`469`	`delete _shards[s];`
`468`	`470`	`}`
`469`	`471`	`delete[] _shards;`
`470`	`472`	`}`
`471`		`- _entity->deregister_hook(_name);`
`472`		`- DorisMetrics::instance()->metric_registry()->deregister_entity(_entity);`
`473`	`473`	`}`
`474`	`474`
`475`	`475`	`Cache::Handle* ShardedLRUCache::insert(const CacheKey& key, void* value, size_t charge,`