[improvement][Resources] Improve details page return to the previous list page (#14951) #14954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update ResourcesServiceImpl.java
feature-14951:Improvement details page
…pache#14951) improve details page return to the previous list page
…pache#14951) improve details page return to the previous list page
…pache#14951) improve details page return to the previous list page
…pache#14951) improve details page return to the previous list page
…pache#14951) improve details page return to the previous list page
…pache#14951) improve details page return to the previous list page
|
@zhutong6688 Good job ! |
|
I use pinia to store data instead of using localStorage directly |
|
I have applied this optimization to the dolphin scheduling used by our company, This Improvement has greatly improved the development efficiency and user experience. |
songjianet
approved these changes
Sep 26, 2023
SbloodyS
added
bug
Codecov Report
@@ Coverage Diff @@
## dev #14954 +/- ##
============================================
- Coverage 38.90% 38.88% -0.02%
+ Complexity 4611 4610 -1
============================================
Files 1236 1236
Lines 43449 43449
Branches 4809 4809
============================================
- Hits 16905 16897 -8
- Misses 24670 24680 +10
+ Partials 1874 1872 -2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Kudos, SonarCloud Quality Gate passed!
|
xdu-chenrj
pushed a commit
to xdu-chenrj/dolphinscheduler
that referenced
this pull request
Oct 30, 2023
…list page (apache#14951) (apache#14954) * Update ResourcesServiceImpl.java * Update index.tsx feature-14951:Improvement details page * Update use-edit.ts * Update use-table.ts * Update index.tsx * [improvement] improve details page return to the previous list page (apache#14951) improve details page return to the previous list page * [improvement] improve details page return to the previous list page (apache#14951) improve details page return to the previous list page * [improvement] improve details page return to the previous list page (apache#14951) improve details page return to the previous list page * [improvement] improve details page return to the previous list page (apache#14951) improve details page return to the previous list page * [improvement] improve details page return to the previous list page (apache#14951) improve details page return to the previous list page * [improvement] improve details page return to the previous list page (apache#14951) improve details page return to the previous list page --------- Co-authored-by: xiangzihao <460888207@qq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Current Problem Is fix #14951 in any version of 3.1.x or 3.2.x or later version
The purpose of this modification is that when we are in the resource list, we click into the resource details page, and then return to the resource list, we can still return to the original resource list。
Brief change log
base on dev branch
add main improve code in dolphinscheduler-ui/src/views/resource/components/resource/edit/index.tsx
add main improve code in dolphinscheduler-ui/src/views/resource/components/resource/edit/use-edit.ts
add main improve code in dolphinscheduler-ui/src/views/resource/components/resource/table/use-table.ts
add main improve code dolphinscheduler-ui/src/views/resource/components/resource/index.tsx
Verify this pull request
This is the test verification of this improvement for problem #14951, as follows：
1、Query resource list unconditionally
2、Query resource list conditionally
As can be seen from the above, whether in the case of conditional or unconditional query of resource files, when you enter the corresponding resource details page and click Save or Return, you can smoothly return to the previous resource list, greatly improving the development efficiency. Otherwise, you will return to the home page every time and lose the query conditions, which greatly reduces the development efficiency。