Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][Resources Project] The details page does not return to the previous list page after returning to the list page #14951

Closed
3 tasks done
zhutong6688 opened this issue Sep 21, 2023 · 3 comments · Fixed by #14954
Assignees
Labels
improvement make more easy to user or prompt friendly

Comments

@zhutong6688
Copy link
Contributor

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

version 3.1.x 、3.2.x
Current Problems
图片
图片
图片
When you come to the task or workflow list interface(Figure 1), click the task edit button on the specified page to enter the task details page(Figure 2). When you return, you will jump to the first page instead of the page where the original task is located(Figure 3). Very unfriendly to the user's experience.

图片
图片
图片
When you come to the list interface of the resource file, click the edit button of the resource file on the specified page to enter the details page of the resource file. When you return or save, you will jump to the first page instead of the page where the original resource file is located. It is also very unfriendly to the user's experience.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@zhutong6688 zhutong6688 added improvement make more easy to user or prompt friendly Waiting for reply Waiting for reply labels Sep 21, 2023
@github-actions
Copy link

Search before asking

  • I had searched in the issues and found no similar feature requirement.

Description

version 3.1.x 、3.2.x
Current Problems
图片
图片
图片
When you come to the task or workflow list interface(Figure 1), click the task edit button on the specified page to enter the task details page(Figure 2). When you return, you will jump to the first page instead of the page where the original task is located(Figure 3). Very unfriendly to the user's experience.

图片
图片
图片
When you come to the list interface of the resource file, click the edit button of the resource file on the specified page to enter the details page of the resource file. When you return or save, you will jump to the first page instead of the page where the original resource file is located. It is also very unfriendly to the user's experience.

Are you willing to submit a PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@zhutong6688
Copy link
Contributor Author

Our company has been using dolphinscheduler. After such a long time of use, we found that if we optimize the resource paging part like me, the development efficiency will increase by an order of magnitude, because it saves a lot of repeated searches and page jumps, especially when modifying the same type of resource files in large quantities.

@zhutong6688
Copy link
Contributor Author

zhutong6688 commented Sep 21, 2023

This time I submitted the code, I gave up using localStorage directly before and insteadly used pinia to store variables. I cannot reopen the previous issue (#13558 (PR #13731)), so I have submitted a new one issue(#14951). Please approve it and I will submit a new PR code by the new issue immediately.

zhutong6688 added a commit to zhutong6688/dolphinscheduler that referenced this issue Sep 22, 2023
zhutong6688 added a commit to zhutong6688/dolphinscheduler that referenced this issue Sep 22, 2023
zhutong6688 added a commit to zhutong6688/dolphinscheduler that referenced this issue Sep 22, 2023
zhutong6688 added a commit to zhutong6688/dolphinscheduler that referenced this issue Sep 22, 2023
zhutong6688 added a commit to zhutong6688/dolphinscheduler that referenced this issue Sep 22, 2023
zhutong6688 added a commit to zhutong6688/dolphinscheduler that referenced this issue Sep 22, 2023
@SbloodyS SbloodyS removed the Waiting for reply Waiting for reply label Oct 13, 2023
SbloodyS added a commit that referenced this issue Oct 13, 2023
…list page (#14951) (#14954)

* Update ResourcesServiceImpl.java

* Update index.tsx

feature-14951:Improvement details page

* Update use-edit.ts

* Update use-table.ts

* Update index.tsx

* [improvement] improve details page return to the previous list page (#14951)

improve details page return to the previous list page

* [improvement] improve details page return to the previous list page (#14951)

improve details page return to the previous list page

* [improvement] improve details page return to the previous list page (#14951)

improve details page return to the previous list page

* [improvement] improve details page return to the previous list page (#14951)

improve details page return to the previous list page

* [improvement] improve details page return to the previous list page (#14951)

improve details page return to the previous list page

* [improvement] improve details page return to the previous list page (#14951)

improve details page return to the previous list page

---------

Co-authored-by: xiangzihao <460888207@qq.com>
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this issue Oct 30, 2023
…list page (apache#14951) (apache#14954)

* Update ResourcesServiceImpl.java

* Update index.tsx

feature-14951:Improvement details page

* Update use-edit.ts

* Update use-table.ts

* Update index.tsx

* [improvement] improve details page return to the previous list page (apache#14951)

improve details page return to the previous list page

* [improvement] improve details page return to the previous list page (apache#14951)

improve details page return to the previous list page

* [improvement] improve details page return to the previous list page (apache#14951)

improve details page return to the previous list page

* [improvement] improve details page return to the previous list page (apache#14951)

improve details page return to the previous list page

* [improvement] improve details page return to the previous list page (apache#14951)

improve details page return to the previous list page

* [improvement] improve details page return to the previous list page (apache#14951)

improve details page return to the previous list page

---------

Co-authored-by: xiangzihao <460888207@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement make more easy to user or prompt friendly
Projects
None yet
2 participants