Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix when update scheduler will execute workflow #13285

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Dec 28, 2022

Purpose of the pull request

close #13286

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added 3.1.x for 3.1.x version improvement make more easy to user or prompt friendly labels Dec 28, 2022
@ruanwenjun ruanwenjun added this to the 3.2.0 milestone Dec 28, 2022
@ruanwenjun ruanwenjun added 3.2.0 for 3.2.0 version and removed 3.1.x for 3.1.x version labels Dec 28, 2022
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_handleMisfire branch from d67d10b to 5699c10 Compare December 28, 2022 03:15
@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2022

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.54%. Comparing base (9199049) to head (5699c10).
Report is 984 commits behind head on dev.

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #13285      +/-   ##
============================================
- Coverage     39.54%   39.54%   -0.01%     
+ Complexity     4291     4290       -1     
============================================
  Files          1072     1072              
  Lines         40541    40541              
  Branches       4665     4662       -3     
============================================
- Hits          16032    16031       -1     
- Misses        22727    22729       +2     
+ Partials       1782     1781       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

25.0% 25.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun merged commit df32ef0 into apache:dev Dec 28, 2022
@ruanwenjun ruanwenjun deleted the dev_wenjun_handleMisfire branch December 28, 2022 06:33
@ruanwenjun ruanwenjun modified the milestones: 3.2.0, 3.0.4 Dec 28, 2022
@zhongjiajie zhongjiajie modified the milestones: 3.0.4, 3.0.5 Dec 29, 2022
@zhongjiajie
Copy link
Member

3.0.4 is expend to apache dist yesterday, so I change to 3.0.5 now

@tracywuhuan
Copy link

@ruanwenjun will it be fixed in 3.1.x?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.1.x for 3.1.x version 3.2.0 for 3.2.0 version backend improvement make more easy to user or prompt friendly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][Scheduler] Use withMisfireHandlingInstructionIgnoreMisfires to handle misfire
6 participants