[Bug] [Server] Once click online schedule time, task will be automatically scheduled

[Radeity]

Purpose of the pull request

• This PR closes [Bug] [Server] Once click online schedule time, task will be automatically scheduled #13089

Brief change log

Current mis-fire strategy is to process cron job immediately. The strategy will be triggered if setting scheduler’s start time earlier than current time.

• Add check when creating and updating schedule, set the start time to current time if it's earlier than current time.

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

[codecov-commenter]

Codecov Report

Merging #13092 (0c599c6) into dev (7c90bf0) will decrease coverage by 0.01%.
The diff coverage is 28.57%.

@@             Coverage Diff              @@
##                dev   #13092      +/-   ##
============================================
- Coverage     39.31%   39.29%   -0.02%     
- Complexity     4247     4279      +32     
============================================
  Files          1061     1069       +8     
  Lines         40050    40317     +267     
  Branches       4604     4636      +32     
============================================
+ Hits          15746    15844      +98     
- Misses        22524    22687     +163     
- Partials       1780     1786       +6     

Impacted Files	Coverage Δ
...heduler/api/service/impl/SchedulerServiceImpl.java	26.79% <23.07%> (+0.01%)	⬆️
.../org/apache/dolphinscheduler/api/enums/Status.java	100.00% <100.00%> (ø)
...uler/api/service/impl/DataAnalysisServiceImpl.java	36.49% <0.00%> (-45.48%)	⬇️
...r/api/service/impl/ProcessInstanceServiceImpl.java	64.28% <0.00%> (-6.10%)	⬇️
...erver/worker/runner/WorkerTaskExecuteRunnable.java	38.51% <0.00%> (-1.23%)	⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java	52.08% <0.00%> (-0.70%)	⬇️
...apache/dolphinscheduler/service/log/LogClient.java	40.40% <0.00%> (-0.60%)	⬇️
...cheduler/api/service/impl/ExecutorServiceImpl.java	43.40% <0.00%> (-0.34%)	⬇️
...duler/dao/repository/impl/TaskInstanceDaoImpl.java	3.38% <0.00%> (-0.19%)	⬇️
...olphinscheduler/plugin/task/python/PythonTask.java	9.72% <0.00%> (-0.14%)	⬇️
... and 36 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[Radeity]

Okay, i'll make some changes that return warning message if setting start time earlier than current time, also change the default start time in front-end to 0:00 of the next day? WDYT.

If no more suggestions, i'll follow the logic mentioned above and finish new code at this weekend.

[ruanwenjun]

If no other concern, I will merge this PR.

[ruanwenjun]

@Radeity Please rebase the upstream dev to solve the dead-link check.

[sonarqubecloud]

SonarCloud Quality Gate failed.   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

22.2% Coverage
0.0% Duplication

[Radeity]

@Radeity Please rebase the upstream dev to solve the dead-link check.

@ruanwenjun Done, thx!

fix

[ruanwenjun]

@Radeity Hi, I submit #13285 to fix this kind of problem, I plan to revert this PR, since the check is not needed now.

[Radeity]

@Radeity Hi, I submit #13285 to fix this kind of problem, I plan to revert this PR, since the check is not needed now.

Okay, anyway, your fix is better, thx!