-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG.md, update release scripts #1807
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -50,14 +50,14 @@ OUTPUT_PATH="${PROJECT}/CHANGELOG.md" | |
pushd ${SOURCE_TOP_DIR} | ||
|
||
# reset content in changelog | ||
git co "${SINCE_TAG}" "${OUTPUT_PATH}" | ||
git checkout "${SINCE_TAG}" "${OUTPUT_PATH}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. my mac didn't like There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. haha, sorry that's an alias i made up in my gitconfig, muscle memory... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. No problem. I tip my hat to you for these scripts in general (automating the RAT in particular is genius, I normally just fix it up manually in arrow-rs) |
||
# remove license header so github-changelog-generator has a clean base to append | ||
sed -i '1,18d' "${OUTPUT_PATH}" | ||
sed -i.bak '1,18d' "${OUTPUT_PATH}" | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Likewise, apparently https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux |
||
|
||
docker run -it --rm \ | ||
-e CHANGELOG_GITHUB_TOKEN=$CHANGELOG_GITHUB_TOKEN \ | ||
-v "$(pwd)":/usr/local/src/your-app \ | ||
githubchangeloggenerator/github-changelog-generator:1.16.2 \ | ||
githubchangeloggenerator/github-changelog-generator \ | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. use latest There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. might want to pin to the latest version number instead to avoid breaking changes in the future. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🤔 https://hub.docker.com/r/githubchangeloggenerator/github-changelog-generator/tags Seems like |
||
--user apache \ | ||
--project arrow-datafusion \ | ||
--since-tag "${SINCE_TAG}" \ | ||
|
@@ -66,7 +66,7 @@ docker run -it --rm \ | |
--output "${OUTPUT_PATH}" \ | ||
"$@" | ||
|
||
sed -i "s/\\\n/\n\n/" "${OUTPUT_PATH}" | ||
sed -i.bak "s/\\\n/\n\n/" "${OUTPUT_PATH}" | ||
|
||
echo '<!--- | ||
Licensed to the Apache Software Foundation (ASF) under one | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python has been moved to its own crate, I believe.