-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CHANGELOG.md, update release scripts #1807
Conversation
@@ -21,7 +21,6 @@ Changelogs are maintained separately for each subproject. Please check out the | |||
changelog file within each subproject folder for more details: | |||
|
|||
* [Datafusion CHANGELOG](./datafusion/CHANGELOG.md) | |||
* [Datafusion Python Binding CHANGELOG](./python/CHANGELOG.md) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
python has been moved to its own crate, I believe.
@@ -50,14 +50,14 @@ OUTPUT_PATH="${PROJECT}/CHANGELOG.md" | |||
pushd ${SOURCE_TOP_DIR} | |||
|
|||
# reset content in changelog | |||
git co "${SINCE_TAG}" "${OUTPUT_PATH}" | |||
git checkout "${SINCE_TAG}" "${OUTPUT_PATH}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my mac didn't like git co
😢
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
haha, sorry that's an alias i made up in my gitconfig, muscle memory...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem. I tip my hat to you for these scripts in general (automating the RAT in particular is genius, I normally just fix it up manually in arrow-rs)
# remove license header so github-changelog-generator has a clean base to append | ||
sed -i '1,18d' "${OUTPUT_PATH}" | ||
sed -i.bak '1,18d' "${OUTPUT_PATH}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Likewise, apparently sed
from mac is slightly different than linux
https://stackoverflow.com/questions/5694228/sed-in-place-flag-that-works-both-on-mac-bsd-and-linux
|
||
docker run -it --rm \ | ||
-e CHANGELOG_GITHUB_TOKEN=$CHANGELOG_GITHUB_TOKEN \ | ||
-v "$(pwd)":/usr/local/src/your-app \ | ||
githubchangeloggenerator/github-changelog-generator:1.16.2 \ | ||
githubchangeloggenerator/github-changelog-generator \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use latest
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
might want to pin to the latest version number instead to avoid breaking changes in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 https://hub.docker.com/r/githubchangeloggenerator/github-changelog-generator/tags
Seems like latest
has no other tag (as in latest
is newer than 1.16.2
but there are no other numbered versions newer than 1.16.2
) 😞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alamb . I gave some suggestions.
- Simplify creating new `ListingTable` [\#1705](https://github.com/apache/arrow-datafusion/issues/1705) | ||
- Implement TableProvider for DataFrameImpl to allow registration of logical plans [\#1698](https://github.com/apache/arrow-datafusion/issues/1698) | ||
- Public Expr simplification API [\#1694](https://github.com/apache/arrow-datafusion/issues/1694) | ||
- Query Optimizer: Add OUTER --\> INNER join conversion [\#1670](https://github.com/apache/arrow-datafusion/issues/1670) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In fact, this is not implemented. BTW, I am worried that there are some errors similar to this one, we just closed repeated issues, but features are not implemented.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not explore this script, which can generate changelog based on PRs already merged?
- Support DataType::Decimal\(15, 2\) in TPC-H benchmark [\#174](https://github.com/apache/arrow-datafusion/issues/174) | ||
- Make `MemoryStream` public [\#150](https://github.com/apache/arrow-datafusion/issues/150) | ||
- Add support for Parquet schema merging [\#132](https://github.com/apache/arrow-datafusion/issues/132) | ||
- Add SQL support for IN expression [\#118](https://github.com/apache/arrow-datafusion/issues/118) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
automation fix looks good to me 👍 looks like we still have a bit of work left to update PRs with proper tags :D
🎉 that would be wonderful @matthewmturner
The basic release instructions https://github.com/apache/arrow-datafusion/blob/master/dev/release/README.md#update-changelogmd Talk about # create the changelog
CHANGELOG_GITHUB_TOKEN=<TOKEN> ./dev/release/update_change_log-all.sh
# review change log / edit issues and labels if needed, rerun until you are happy with the result
git commit -a -m 'Create changelog for release' But the "until you are happy with the result" leaves a lot to the imagination 😆 Basically what I did was run that script (it updates the Examples of things that I did:
The most questionable thing related to labels were:
It would be great to have some more help here. Some thoughts:
Something else I haven't even been looking into is releasing the python bindings and releasing ballista lol -- so any help you want to lend in there would be awesome |
Which issue does this PR close?
Re #1587
You can see a rendered version here: https://github.com/alamb/arrow-datafusion/blob/alamb/changelog_for_7.0.0/datafusion/CHANGELOG.md
Rationale for this change
Trying to tell the 🌎 🌍 🌏 about DataFusion
What changes are included in this PR?
It was created using
🤯 what a lot of stuff happened!!!
Since this file is automatically generated: to make changes, please edit the ticket subjects / labels directly (or tag me
@alamb
if you don't have the permissions to do so).I am hoping to create a release candidate over the weekend (as I will be largely offline starting next Thursday Feb 17 for a week or so) so I can do the release next week before I head out.