fix: Panic/correctness issue in variance GroupsAccumulator #12615
+5
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug was in the orginal implementation in apache#12095. This fixes the issue and modify a test case such that it would have caught it.
eejbyfeldt
changed the title
jayzhan211
reviewed
Sep 25, 2024
| @@ -470,7 +470,7 @@ impl VarianceGroupsAccumulator { | |||
|
|
|||
| if let StatsType::Sample = self.stats_type { | |||
| counts.iter_mut().for_each(|count| { | |||
| *count -= 1; | |||
| *count = count.saturating_sub(1); | |||
There was a problem hiding this comment.
Should we return error if count is already 0?
There was a problem hiding this comment.
No, I think producing null is the expected behavior. Note that we use the counts to calculate the null array after this.
|
Thanks @eejbyfeldt and @jayzhan211 |
bgjackma
pushed a commit
to bgjackma/datafusion
that referenced
this pull request
Sep 25, 2024
The bug was in the orginal implementation in apache#12095. This fixes the issue and modify a test case such that it would have caught it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #12616.
Rationale for this change
The bug was in the orginal implementation in #12095. This fixes the
issue and modify a test case such that it would have caught it.
Current code panics in debug builds and produces incorrect results in release.
What changes are included in this PR?
Use
staturating_subinstead to correct the behavior.Are these changes tested?
Modified test case.
Are there any user-facing changes?
No,