Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Panic/correctness issue in variance GroupsAccumulator #12616

Closed
eejbyfeldt opened this issue Sep 25, 2024 · 0 comments · Fixed by #12615
Closed

Panic/correctness issue in variance GroupsAccumulator #12616

eejbyfeldt opened this issue Sep 25, 2024 · 0 comments · Fixed by #12615
Labels
bug Something isn't working

Comments

@eejbyfeldt
Copy link
Contributor

Describe the bug

When using the sample variance and there is no values in a group we will do a -1 on a 0 usize. This leads to wrong results in release mode and panic in debug.

To Reproduce

No response

Expected behavior

No response

Additional context

No response
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Panic/correctness issue in variance GroupsAccumulator eejbyfeldt/datafusion
1 participant
@eejbyfeldt