Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Proposal for source release process #556

Merged
merged 11 commits into from
Jun 14, 2024

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Jun 11, 2024

Which issue does this PR close?

Part of #394

Rationale for this change

We want to create our first source release soon, so we need to define the process.

What changes are included in this PR?

Add proposed source release process to release documentation (rendered version).

How are these changes tested?

Not tested

@andygrove andygrove marked this pull request as ready for review June 11, 2024 15:30
@@ -17,7 +17,7 @@ specific language governing permissions and limitations
under the License.
-->

# Comet Release Process
# Comet Source Release Process
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is Source means here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are defining the process for making an official ASF release, which must be a source tarball.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is the DataFusion 39 release, for example:

Screenshot 2024-06-11 at 12 24 15 PM

- Push a release candidate tag (e.g. 0.1.0-rc1) to the Apache repository
Here are the steps, using the 0.1.0 release as an example:

- Create a release branch from the latest commit in main (e.g. `git checkout -b release-0.1.0`) and push to the Apache repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just thinking - perhaps we can convert all steps into github commands?

@andygrove
Copy link
Member Author

Thanks for the review @comphead. I added the git commands for most steps.

Create a release branch from the latest commit in main and push to the Apache repo:

```shell
get fetch apache
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apache is a different repo?

Copy link
Member Author

@andygrove andygrove Jun 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's the name I use for my remote, but it would be good to clarify this in the docs.

$ git remote -v | grep apache
apache	git@github.com:apache/datafusion-comet.git (fetch)
apache	git@github.com:apache/datafusion-comet.git (push)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I thought it might be a nickname for a particular repo. It'd be good to make it clear in the doc.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have added this

@andygrove
Copy link
Member Author

@viirya @comphead I think I have addressed all feedback now. Could I get another review?

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks @andygrove
👍

existing Spark jobs and report any functional issues or performance regressions.

Another way of verifying the release is to follow the
[Comet Benchmarking Guide](https://datafusion.apache.org/comet/contributor-guide/benchmarking.html) and compare
Copy link
Contributor

@comphead comphead Jun 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it just comes to my mind if its possible to generate benches automatically per release. So Comet have a trend

@andygrove
Copy link
Member Author

Thanks for the reviews @comphead and @viirya. Let's go ahead and merge and we can continue to iterate on this as needed.

@andygrove andygrove merged commit 4be2d30 into apache:main Jun 14, 2024
43 checks passed
@andygrove andygrove deleted the source-release-process branch June 14, 2024 15:40
himadripal pushed a commit to himadripal/datafusion-comet that referenced this pull request Sep 7, 2024
* Source release process proposal

* small refinement

* add more detail

* fix

* more detail

* title

* prettier

* ASF header

* address feedback
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants