fix: GH-873 App bundle builds to obey --versionCode arguments #941
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Platforms affected
Android
Motivation and Context
There was an issue when building app bundles where it did not obey flags. This was an error in the original implementation where arguments was only propagated to gradle if the package type was "apk". This PR corrects this mistake.
Closes #873
Description
Moved a line that pushes gradle arguments outside of the package type condition, as it is applicable
to both package types.
Unit tests was added for both package types to ensure they both have args filled out as expected.
Testing
NPM test runs successfully, including 2 new tests that was added.
I've also ran
aapt
andbundletool
to inspect the built files to ensure that the versionCode was as expected.Checklist
(platform)
if this change only applies to one platform (e.g.(android)
)