-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Android App Bundle: --versionCode ignored with --packageType=bundle #873
Comments
Thanks for the report, I'll try to take a look at this tonight. |
I have reproduced this issue and confirmed this as a bug. |
I do not know why It's getting late for me so I have to pick this back up another time. |
@breautek |
No sorry, I haven't had a chance to relook at this. Afaik, the above workaround is the only way to properly set the versionCode 😭 |
And the issue all along was... I omitted passing down the flags if the package type was bundle in the original bundle implementation 🤦♂️ Amazing what kind of work can do when you ignore the issue for 3 months. |
Bug Report
Problem
The following command ignore versionCode parameter when use --packageType=bundle
What is expected to happen?
versionCode must not ignored when --packageType=bundle is used
What does actually happen?
Now cordova uses version from config.xml and generates version instead of using the specified in --versionCode parameters
Information
cordova --version 9.0.0 (cordova-lib@9.0.1)
Command or Code
Environment, Platform, Device
Version information
Checklist
The text was updated successfully, but these errors were encountered: