Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restore key event handlers when DOM element is fullscreen #1157

Merged
merged 2 commits into from
Mar 30, 2021
Merged

fix: restore key event handlers when DOM element is fullscreen #1157

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d698fd2
GH-1156: Restore key event handlers when a DOM element is fullscreen
Jan 21, 2021
12fbca3
Remove unwanted whitespace in condition
goffioul Jan 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion framework/src/org/apache/cordova/CordovaWebViewImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -255,7 +255,12 @@ public WrapperView(Context context, CordovaWebViewEngine engine) {

@Override
public boolean dispatchKeyEvent(KeyEvent event) {
return engine.getView().dispatchKeyEvent(event);
boolean ret = engine.getView().dispatchKeyEvent(event);
if (! ret) {
goffioul marked this conversation as resolved.
Show resolved Hide resolved
// If the engine didn't handle the event, handle it normally.
ret = super.dispatchKeyEvent(event);
}
return ret;
}
}

Expand Down