Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: restore key event handlers when DOM element is fullscreen #1157

Merged
merged 2 commits into from
Mar 30, 2021
Merged

fix: restore key event handlers when DOM element is fullscreen #1157

merged 2 commits into from
Mar 30, 2021

Conversation

goffioul
Copy link
Contributor

Make sure to call dispatchKeyEvent from base class in WrapperView, if the event hasn't been handled by the engine.

Fixes #1156

apacheGH-1156: Restore key event handlers when a DOM element is fulls…
d698fd2 
…creen

Make sure to call dispatchKeyEvent from base class in WrapperView, if
the event hasn't been handled by the engine.
breautek
breautek approved these changes Jan 21, 2021
View reviewed changes
Copy link
Contributor

@breautek breautek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

Thank you for your contribution.

@breautek breautek requested review from dpogue, erisu and timbru31 January 21, 2021 21:22
@goffioul @erisu
Remove unwanted whitespace in condition
12fbca3 
Co-authored-by: エリス <erisu@users.noreply.github.com>
@erisu erisu changed the title GH-1156: Restore key event handlers when a DOM element is fullscreen fix: restore key event handlers when DOM element is fullscreen Mar 28, 2021
@erisu erisu added the bug label Mar 28, 2021
@erisu erisu added this to the 9.1.0 milestone Mar 28, 2021
@erisu erisu merged commit 6cbf69d into apache:master Mar 30, 2021
wedgberto pushed a commit to wedgberto/cordova-android that referenced this pull request May 17, 2022
@goffioul @erisu @wedgberto
fix: restore key event handlers when DOM element is fullscreen (apach…
3284e91 
…e#1157)

* apacheGH-1156: Restore key event handlers when a DOM element is fullscreen

Make sure to call dispatchKeyEvent from base class in WrapperView, if
the event hasn't been handled by the engine.

* Remove unwanted whitespace in condition

Co-authored-by: エリス <erisu@users.noreply.github.com>
Co-authored-by: Michael Goffioul <michael.goffioul@lincor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breautek breautek breautek approved these changes

@erisu erisu erisu approved these changes

@dpogue dpogue Awaiting requested review from dpogue

@timbru31 timbru31 Awaiting requested review from timbru31

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
9.1.0
Development

Successfully merging this pull request may close these issues.

Key event not reaching JS when a DOM element is fullscreen
3 participants
@goffioul @erisu @breautek