-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Api: update command domainId/account descriptions #7876
Conversation
… if the account is missing.
@blueorangutan package |
@soreana a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
api/src/main/java/org/apache/cloudstack/api/command/user/volume/CreateVolumeCmd.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/apache/cloudstack/api/command/user/volume/UploadVolumeCmd.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/apache/cloudstack/api/command/user/snapshot/CreateSnapshotCmd.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java
Outdated
Show resolved
Hide resolved
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java
Outdated
Show resolved
Hide resolved
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6805 |
Codecov Report
@@ Coverage Diff @@
## 4.18 #7876 +/- ##
============================================
+ Coverage 13.02% 13.04% +0.01%
- Complexity 9039 9067 +28
============================================
Files 2720 2720
Lines 257094 257236 +142
Branches 40092 40103 +11
============================================
+ Hits 33489 33552 +63
- Misses 219401 219474 +73
- Partials 4204 4210 +6
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Thanks @weizhouapache I've updated the pr, let me know if it requires more changes. |
@blueorangutan package |
@soreana a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6817 |
api/src/main/java/org/apache/cloudstack/api/command/user/network/CreateNetworkCmd.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code lgtm
@DaanHoogland can you review it ? Thanks
only parameter description fields have changed, merging |
Description
This PR fixes the issue #7776 and the spelling issues mentioned in: apache/cloudstack-go#64
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
How Has This Been Tested?
This PR doesn't need specific testing, it only changes some api call descriptions.