Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api: update command domainId/account descriptions #7876

Merged
merged 4 commits into from
Aug 20, 2023

Conversation

soreana
Copy link
Member

@soreana soreana commented Aug 16, 2023

Description

This PR fixes the issue #7776 and the spelling issues mentioned in: apache/cloudstack-go#64

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

This PR doesn't need specific testing, it only changes some api call descriptions.

@soreana
Copy link
Member Author

soreana commented Aug 16, 2023

@blueorangutan package

@blueorangutan
Copy link

@soreana a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6805

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #7876 (07da2b1) into 4.18 (72e3491) will increase coverage by 0.01%.
Report is 11 commits behind head on 4.18.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               4.18    #7876      +/-   ##
============================================
+ Coverage     13.02%   13.04%   +0.01%     
- Complexity     9039     9067      +28     
============================================
  Files          2720     2720              
  Lines        257094   257236     +142     
  Branches      40092    40103      +11     
============================================
+ Hits          33489    33552      +63     
- Misses       219401   219474      +73     
- Partials       4204     4210       +6     
Files Changed Coverage Δ
.../api/command/admin/ratelimit/ResetApiLimitCmd.java 0.00% <ø> (ø)
...tungsten/api/command/ListTungstenFabricTagCmd.java 0.00% <ø> (ø)
...e/datastore/util/ListElastistorVolumeResponse.java 0.00% <ø> (ø)
...dstack/api/response/LdapConfigurationResponse.java 0.00% <ø> (ø)
...dstack/api/response/LinkAccountToLdapResponse.java 93.33% <ø> (ø)
...udstack/api/response/LinkDomainToLdapResponse.java 85.71% <ø> (ø)
...loud/api/auth/DefaultLoginAPIAuthenticatorCmd.java 0.00% <ø> (ø)

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@soreana
Copy link
Member Author

soreana commented Aug 17, 2023

Thanks @weizhouapache I've updated the pr, let me know if it requires more changes.

@soreana
Copy link
Member Author

soreana commented Aug 17, 2023

@blueorangutan package

@blueorangutan
Copy link

@soreana a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6817

@weizhouapache weizhouapache changed the title Api command descriptions Api: update command domainId/account descriptions Aug 18, 2023
Copy link
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@DaanHoogland can you review it ? Thanks

@DaanHoogland
Copy link
Contributor

only parameter description fields have changed, merging

@DaanHoogland DaanHoogland merged commit d296f54 into apache:4.18 Aug 20, 2023
@soreana soreana deleted the api-command-descriptions branch August 20, 2023 15:27
@soreana soreana restored the api-command-descriptions branch September 7, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants