Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling #64

Merged
merged 2 commits into from
Nov 7, 2023
Merged

Fix spelling #64

merged 2 commits into from
Nov 7, 2023

Conversation

jbampton
Copy link
Member

@jbampton jbampton commented Aug 1, 2023

No description provided.

@soreana
Copy link
Member

soreana commented Aug 4, 2023

@rohityadavcloud I will take care of this. I'm updating the domainid description, I would add these as well.

Checkout the following pr please:
apache/cloudstack#7776

@soreana
Copy link
Member

soreana commented Aug 4, 2023

Btw, I don't have a permission to assign PRs in this repository, feel free to assign this PR to me.

@soreana
Copy link
Member

soreana commented Aug 16, 2023

@jbampton I've added the changes in the generate/listApis.json file to the PR apache/cloudstack#7876, can you please exclude them from your PR?

@soreana
Copy link
Member

soreana commented Aug 20, 2023

@rohityadavcloud My PR got merged, I would like to update the generated.go file but I couldn't find any docs about it. This is the only thing I found :D

The SDK relies on the generate.go script to auto generate the code for all the supported APIs listed in the listApis.json file. The listAPIs.json file holds the output of listApis command for a specific release of CloudStack.

# Run it via the Makefile
make all

@soreana soreana self-assigned this Aug 25, 2023
@DaanHoogland
Copy link
Contributor

@soreana @rohityadavcloud if listApis.json is generated, should it be in the repository? As opposed to the generation script/command I mean.

@jbampton can you remove the file from your PR, please?

@jbampton
Copy link
Member Author

jbampton commented Nov 6, 2023

All done now @DaanHoogland thanks

@DaanHoogland DaanHoogland merged commit 93eec05 into apache:main Nov 7, 2023
1 check passed
@jbampton jbampton deleted the fix-spelling branch November 7, 2023 08:50
@soreana
Copy link
Member

soreana commented Nov 7, 2023

@soreana @rohityadavcloud if listApis.json is generated, should it be in the repository? As opposed to the generation script/command I mean.

@jbampton can you remove the file from your PR, please?

@DaanHoogland I'm not sure why they're there. I suppose the generated files are bundled so that the SDK knows what API calls are available.

@DaanHoogland
Copy link
Contributor

I understand @soreana , but I'd expect it to be generated on build- or run-time. Maybe we can improve it that way?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants