-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix spelling #64
Fix spelling #64
Conversation
@rohityadavcloud I will take care of this. I'm updating the domainid description, I would add these as well. Checkout the following pr please: |
Btw, I don't have a permission to assign PRs in this repository, feel free to assign this PR to me. |
@jbampton I've added the changes in the generate/listApis.json file to the PR apache/cloudstack#7876, can you please exclude them from your PR? |
@rohityadavcloud My PR got merged, I would like to update the generated.go file but I couldn't find any docs about it. This is the only thing I found :D
|
@soreana @rohityadavcloud if listApis.json is generated, should it be in the repository? As opposed to the generation script/command I mean. @jbampton can you remove the file from your PR, please? |
All done now @DaanHoogland thanks |
@DaanHoogland I'm not sure why they're there. I suppose the generated files are bundled so that the SDK knows what API calls are available. |
I understand @soreana , but I'd expect it to be generated on build- or run-time. Maybe we can improve it that way? |
No description provided.