Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: adding ingressClassName field to the Ingress trait #5797

Merged
merged 1 commit into from
Aug 28, 2024

Conversation

lsergio
Copy link
Contributor

@lsergio lsergio commented Aug 26, 2024

Adds the ingressClassName field to the Ingress trait for use in the Ingress creation.

Closes #5793

Release Note

feat: Added ingressClassName field to the Ingress trait

Copy link
Contributor

@squakez squakez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. However, I'd instead create a new unit test to verify that by default, there is no ìngressClassName` set.

@lsergio
Copy link
Contributor Author

lsergio commented Aug 26, 2024

LGTM. However, I'd instead create a new unit test to verify that by default, there is no ìngressClassName` set.

Good idea. I'll do it

@lsergio lsergio force-pushed the feat/5793-ingress-class-name branch from 2bfb4ce to b8fc93d Compare August 26, 2024 13:40
@squakez squakez merged commit 87d5ffb into apache:main Aug 28, 2024
10 checks passed
@lsergio lsergio deleted the feat/5793-ingress-class-name branch August 28, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ingressClassName field to Ingress trait
3 participants