Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ingressClassName field to Ingress trait #5793

Closed
lsergio opened this issue Aug 23, 2024 · 2 comments · Fixed by #5797
Closed

Add ingressClassName field to Ingress trait #5793

lsergio opened this issue Aug 23, 2024 · 2 comments · Fixed by #5797
Assignees
Labels
kind/feature New feature or request
Milestone

Comments

@lsergio
Copy link
Contributor

lsergio commented Aug 23, 2024

Requirement

The Ingress spec has the ingressClassName field which is a replacement for the deprecated kubernetes.io/ingress.class annotation.
I think it might be interesting to add the ingressClassName field to the Ingress trait to be compatible with the recommended way of defining the class name.

Problem

It doesn't really block me from creating the Ingress. It will be a problem if the deprecated annotation someday becomes unsupported.

Proposal

Just add the field to the Ingress trait as a non-required information and copy it to the corresponding Ingress attribute.

Open questions

No response

@lsergio lsergio added the kind/feature New feature or request label Aug 23, 2024
@lsergio
Copy link
Contributor Author

lsergio commented Aug 23, 2024

I can work on that if it's a good idea.

@lsergio lsergio changed the title Add ingressClassName field do Ingress trait Add ingressClassName field to Ingress trait Aug 23, 2024
@squakez
Copy link
Contributor

squakez commented Aug 26, 2024

Yeah thanks, it would be great.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants