Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate AWS IOs (Java) using AWS SDK v1 in favor of IOs in amazon-web-services2 #22093

Merged
merged 3 commits into from
Jul 8, 2022

Conversation

mosche
Copy link
Member

@mosche mosche commented Jun 29, 2022

Currently there's two different versions of AWS IO connectors in Beam for the Java SDK:

This deprecates IOs in both, the amazon-web-services and kinesis module in favor of the amazon-web-services2 module and closes #21249.

After a few Beam releases both, the amazon-web-services and kinesis module will be removed.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Choose reviewer(s) and mention them in a comment (R: @username).
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
  • Update CHANGES.md with noteworthy changes.
  • If this contribution is large, please file an Apache Individual Contributor License Agreement.

See the Contributor Guide for more tips on how to make review process smoother.

To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md

GitHub Actions Tests Status (on master branch)

Build python source distribution and wheels
Python tests
Java tests

See CI.md for more information about GitHub Actions CI.

@mosche
Copy link
Member Author

mosche commented Jun 29, 2022

R: @aromanenko-dev
R: @aaltay

Copy link
Contributor

@aromanenko-dev aromanenko-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Long time expected deprecation since it's a burden to support two similar modules.

LGTM, just a one suggestion.

@aromanenko-dev
Copy link
Contributor

aromanenko-dev commented Jun 29, 2022

Interesting that no any Jenkins jobs were triggered for this PR.... Seems like it's a Jenkins issue

@aromanenko-dev
Copy link
Contributor

retest this please

@aromanenko-dev
Copy link
Contributor

Run Java PreCommit

@mosche
Copy link
Member Author

mosche commented Jun 29, 2022

retest this please

@mosche
Copy link
Member Author

mosche commented Jul 8, 2022

retest this please

@mosche mosche merged commit f5435c0 into apache:master Jul 8, 2022
@mosche mosche deleted the 21249-DeprecateAWS1 branch July 8, 2022 07:00
lostluck pushed a commit to lostluck/beam that referenced this pull request Aug 26, 2022
psolomin added a commit to psolomin/beam-samples that referenced this pull request Apr 15, 2023
Old Kinesis connector is deprecated by apache/beam#22093
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate amazon-web-services & kinesis module (SDK v1)
2 participants