-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate AWS IOs (Java) using AWS SDK v1 in favor of IOs in amazon-web-services2 #22093
Conversation
R: @aromanenko-dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Long time expected deprecation since it's a burden to support two similar modules.
LGTM, just a one suggestion.
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/s3/S3FileSystem.java
Show resolved
Hide resolved
Interesting that no any Jenkins jobs were triggered for this PR.... Seems like it's a Jenkins issue |
retest this please |
Run Java PreCommit |
retest this please |
3f61943
to
967edbe
Compare
retest this please |
Old Kinesis connector is deprecated by apache/beam#22093
Currently there's two different versions of AWS IO connectors in Beam for the Java SDK:
This deprecates IOs in both, the
amazon-web-services
andkinesis
module in favor of theamazon-web-services2
module and closes #21249.After a few Beam releases both, the
amazon-web-services
andkinesis
module will be removed.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
R: @username
).addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI.