Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable cargo / build caching for MIRI runs #899

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Nov 1, 2021

Which issue does this PR close?

Next attempt t close #879

Rationale for this change

MIRI is still failing intermittently on Master in a way we can't reproduce locally. Last time in #892 changing the caching seemed to help. This time let's entirely remove the caching to try and confirm (or rule out) it causing the issue

What changes are included in this PR?

Disable all caching for MIRI CI run

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of arrow-rs label Nov 1, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #899 (6b235ef) into master (a7547d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #899   +/-   ##
=======================================
  Coverage   82.30%   82.30%           
=======================================
  Files         168      168           
  Lines       48031    48031           
=======================================
  Hits        39532    39532           
  Misses       8499     8499           
Impacted Files Coverage Δ
parquet_derive/src/parquet_field.rs 65.98% <0.00%> (-0.23%) ⬇️
arrow/src/array/transform/mod.rs 85.33% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7547d5...6b235ef. Read the comment docs.

@alamb
Copy link
Contributor Author

alamb commented Nov 1, 2021

Well, MIRI has passed but given the experience last time I am not sure if that is relevant. Merging this in on the theory it can't hurt...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIRI check is failing on master
2 participants