Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use different caching for MIRI runs #892

Merged
merged 2 commits into from
Oct 31, 2021
Merged

Conversation

alamb
Copy link
Contributor

@alamb alamb commented Oct 31, 2021

Which issue does this PR close?

Closes #879

Rationale for this change

MIRI is failing in some "can not reproduce" way on github.

We have previously seen github fail due to ancient stuff in the cache (e.g. #878), though in that case it was related to the cargo cache

What changes are included in this PR?

Change the cache setting for the MIRI job to:

  1. Be different (and thus not use whatever is wrong with the current one)
  2. More closely follow the other jobs caching

Are there any user-facing changes?

No

@alamb alamb added the development-process Related to development process of arrow-rs label Oct 31, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 31, 2021

Codecov Report

Merging #892 (82f2236) into master (898924f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #892   +/-   ##
=======================================
  Coverage   82.45%   82.45%           
=======================================
  Files         168      168           
  Lines       48231    48231           
=======================================
  Hits        39767    39767           
  Misses       8464     8464           
Impacted Files Coverage Δ
parquet/src/arrow/array_reader.rs 77.72% <0.00%> (-0.09%) ⬇️
parquet/src/encodings/encoding.rs 94.67% <0.00%> (+0.19%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 898924f...82f2236. Read the comment docs.

Copy link
Member

@jimexist jimexist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alamb
Copy link
Contributor Author

alamb commented Oct 31, 2021

I plan to merge this in once CI passes.

@jimexist
Copy link
Member

Alas one of the two true hard problems in computer science.

@alamb alamb merged commit 2310936 into apache:master Oct 31, 2021
@alamb alamb deleted the alamb/poisoned_cache branch October 31, 2021 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of arrow-rs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MIRI check is failing on master
3 participants