Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

refactor: merge core superset-ui packages #768

Merged
merged 1 commit into from
Sep 3, 2020
Merged

refactor: merge core superset-ui packages #768

merged 1 commit into from
Sep 3, 2020

Conversation

ktmud
Copy link
Contributor

@ktmud ktmud commented Sep 3, 2020

A colossal of moving files around to merge all core superset-ui packages into one monopackage @superset-ui/core. This removes the needs to maintain correct inter-package dependencies and will enable us to iterate on Superset's charting foundation faster.

Everything from the previous packages are exported at root. For most cases, the implication for end users is to simply replace their import .. from '@superset-ui/xxx' to import .. from '@superset-ui/core'. More refactoring may be planned to make some of the exports less ambiguous.

The work was done in a feature branch. This PR merges the feature branch to master. Here is a list of all related PRs:

  1. move translation, connection, query to core (refactor: move translation, connection, query to core #729)
  2. update encodable to remove formatter inter-dependency (build: update encodable dependency #744)
  3. move number-format and time-format to core (build: move number-format and time-format to core #730)
  4. move superset-ui/dimension to core (refactor: move superset-ui/dimension to core #732)
  5. move superset-ui/color to core (refactor: move superset-ui/color to core #755)
  6. move superset-ui/style to core (refactor: move superset-ui/style to core #756)
  7. move superset-ui/validator to core (refactor: move superset-ui/validator to core #757)
  8. move superset-ui/chart-composition to core (refactor: move superset-ui/chart-composition to core #759)
  9. move superset-ui/chart to core (refactor: move chart to core #760)

All packages are merged except @superset-ui/chart-controls because if we move it to core and export it from there, it will import the i18n function t(...) before translations are initialized (currently users have to import { configure } from '@superset-ui/core' to setup the language pack.

Migration plan:

  • Deprecate old packages in NPM
  • Publish a minor version (0.15.0) for all packages and plugins
  • Update deck.gl and other other plugins not in this monorepo.
  • Replace all packages in incubator-superset

💔 Breaking Changes

🏆 Enhancements

🏠 Internal

1. move translation, connection, query to core (#729)
2. update encodable to remove formatter inter-dependency (#744)
3. move number-format and time-format to core (#730)
4. move superset-ui/dimension to core (#732)
5. move superset-ui/color to core (#755)
6. move superset-ui/style to core (#756)
7. move superset-ui/validator to core (#757)
8: move superset-ui/chart-composition to core (#759)
9: move superset-ui/chart to core (#760)
@ktmud ktmud requested a review from a team as a code owner September 3, 2020 18:23
@vercel
Copy link

vercel bot commented Sep 3, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/superset/superset-ui/qfkiy8v0b
✅ Preview: https://superset-ui-git-monopackage.superset.vercel.app

@codecov
Copy link

codecov bot commented Sep 3, 2020

Codecov Report

Merging #768 into master will decrease coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #768      +/-   ##
==========================================
- Coverage   24.92%   24.90%   -0.03%     
==========================================
  Files         348      353       +5     
  Lines        7799     7839      +40     
  Branches      985     1003      +18     
==========================================
+ Hits         1944     1952       +8     
- Misses       5751     5785      +34     
+ Partials      104      102       -2     
Impacted Files Coverage Δ
...ntrols/src/components/CertifiedIconWithTooltip.tsx 33.33% <ø> (ø)
...-ui-chart-controls/src/components/MetricOption.tsx 53.33% <ø> (ø)
...art-controls/src/components/RadioButtonControl.tsx 9.09% <ø> (ø)
...ckages/superset-ui-chart-controls/src/constants.ts 100.00% <ø> (ø)
...ckages/superset-ui-chart-controls/src/sections.tsx 100.00% <ø> (ø)
...i-chart-controls/src/utils/expandControlConfig.tsx 100.00% <ø> (+26.66%) ⬆️
...erset-ui-core/src/chart-composition/ChartFrame.tsx 100.00% <ø> (ø)
...i-core/src/chart-composition/legend/WithLegend.tsx 100.00% <ø> (ø)
...ore/src/chart-composition/tooltip/TooltipFrame.tsx 100.00% <ø> (ø)
...ore/src/chart-composition/tooltip/TooltipTable.tsx 100.00% <ø> (ø)
... and 215 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02b8add...d268e00. Read the comment docs.

Copy link
Contributor

@kristw kristw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so long!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants