This repository has been archived by the owner on Dec 10, 2021. It is now read-only.
refactor: move chart to core #760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/superset/superset-ui/qfkiy8v0b |
ktmud
force-pushed
the
monopackage-move-chart
branch
from
7240bcf
to
c0f4e04
Compare
ktmud
force-pushed
the
monopackage-move-chart
branch
from
c0f4e04
to
5d85c9a
Compare
ktmud
force-pushed
the
monopackage-move-chart
branch
from
5d85c9a
to
c49bacc
Compare
ktmud
force-pushed
the
monopackage-move-chart
branch
from
c49bacc
to
4b56f2e
Compare
ktmud
force-pushed
the
monopackage-move-chart
branch
from
4b56f2e
to
21ae69f
Compare
Codecov Report
@@ Coverage Diff @@
## monopackage #760 +/- ##
===============================================
+ Coverage 24.79% 24.90% +0.10%
===============================================
Files 352 353 +1
Lines 7845 7839 -6
Branches 1003 1003
===============================================
+ Hits 1945 1952 +7
+ Misses 5796 5785 -11
+ Partials 104 102 -2
Continue to review full report at Codecov.
|
ktmud
force-pushed
the
monopackage
branch
2 times, most recently
from
5d86af4
to
391f4cd
Compare
ktmud
force-pushed
the
monopackage-move-chart
branch
from
21ae69f
to
9a72816
Compare
kristw
approved these changes
Sep 3, 2020
ktmud
changed the title
ktmud
added a commit
that referenced
this pull request
Sep 3, 2020
1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757) 8: move superset-ui/chart-composition to core (#759) 9: move superset-ui/chart to core (#760)
4 tasks
ktmud
added a commit
that referenced
this pull request
Sep 3, 2020
1. move translation, connection, query to core (#729) 2. update encodable to remove formatter inter-dependency (#744) 3. move number-format and time-format to core (#730) 4. move superset-ui/dimension to core (#732) 5. move superset-ui/color to core (#755) 6. move superset-ui/style to core (#756) 7. move superset-ui/validator to core (#757) 8. move superset-ui/chart-composition to core (#759) 9. move superset-ui/chart to core (#760)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
💔 Breaking Changes
🏆 Enhancements
The final and biggest PR for merging superset-ui packages.
Related: #728 #729 #730 #732 #755 #756 #757 #759