Skip to content
This repository has been archived by the owner on Dec 10, 2021. It is now read-only.

Use d3 localization for time-format package #238

Closed
oskarhinc opened this issue Oct 15, 2019 · 4 comments
Closed

Use d3 localization for time-format package #238

oskarhinc opened this issue Oct 15, 2019 · 4 comments
Labels
#enhancement New feature or request

Comments

@oskarhinc
Copy link

Is your feature request related to a problem? Please describe.
The date and time presented within the time-format package are not translated for different languages. It could be changed, so the localization would be supported.

Describe the solution you'd like
D3 library supports localization, as described in the project description. The easiest way would be probably changing the default locale at a proper moment.

Describe alternatives you've considered
According to d3 docs it is also possible to avoid setting the default locale multiple times, and use proper locale definition when needed, but this might be more complex.

@issue-label-bot issue-label-bot bot added the #enhancement New feature or request label Oct 15, 2019
@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@cdmikechen
Copy link

cdmikechen commented Dec 12, 2019

I have also encountered this problem, and I think I can analyze superset-ui codes and solve it

@cdmikechen
Copy link

cdmikechen commented Dec 16, 2019

@oskarhinc Can refer to
cdmikechen/incubator-superset@701c844
cdmikechen@ebec706
cdmikechen/superset-ui-plugins@99dcbe5

Have add a d3locale json to support formatter, and change some functions to adapt to new code. You can test it to see if it works.

kristw pushed a commit that referenced this issue Apr 17, 2020
Bumps [@vx/axis](https://github.com/hshoff/vx) from 0.0.191 to 0.0.192.
- [Release notes](https://github.com/hshoff/vx/releases)
- [Changelog](https://github.com/hshoff/vx/blob/master/CHANGELOG.md)
- [Commits](airbnb/visx@v0.0.191...v0.0.192)

Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
@villebro
Copy link
Contributor

The codebase on this repo has been moved to the main Apache Superset repo, and consequently the repo is in the process of being archived. See the Superset Improvement Proposal for details: apache/superset#13013 . While all currently open issues and PRs will be closed, we encourage you to reopen this issue on the main repo if it is still relevant.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
#enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants