Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow the months and days embedded within charts to be displayed in Portuguese #8388

Closed
oskarhinc opened this issue Oct 14, 2019 · 5 comments
Labels
enhancement:request Enhancement request submitted by anyone from the community inactive Inactive for >= 30 days

Comments

@oskarhinc
Copy link
Contributor

Is your feature request related to a problem? Please describe.
We could add localization for months and days names for the charts, so it's translated to Portuguese.

Describe the solution you'd like
We could use mechanism built in d3 and moment libraries, to use proper localization here.

Additional context
If it'll be quick and easy to achieve, we can also add support for other languages that are supported by the libraries.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the label #enhancement to this issue, with a confidence of 0.98. Please mark this comment with 👍 or 👎 to give our bot feedback!

Links: app homepage, dashboard and code for this bot.

@issue-label-bot issue-label-bot bot added the enhancement:request Enhancement request submitted by anyone from the community label Oct 14, 2019
@oskarhinc
Copy link
Contributor Author

After I've dived into the implementation, it occurs that those components are defined in plugins from a separate repo, which uses d3 library for date and time formatters. D3 supports localization, however, it's not used by the plugins, so I've created an issue there for supporting it.

@oskarhinc
Copy link
Contributor Author

Closed by mistake - reopening

@oskarhinc oskarhinc reopened this Oct 15, 2019
@cdmikechen
Copy link
Contributor

I have also encountered this problem, and I am going to analyze and solve it

@stale
Copy link

stale bot commented Feb 10, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue .pinned to prevent stale bot from closing the issue.

@stale stale bot added the inactive Inactive for >= 30 days label Feb 10, 2020
@stale stale bot closed this as completed Feb 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement:request Enhancement request submitted by anyone from the community inactive Inactive for >= 30 days
Projects
None yet
Development

No branches or pull requests

2 participants