Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.17: [anza migration] fix: use the correct log filter for non-unix (backport of #245) #287

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

mergify[bot]
Copy link

@mergify mergify bot commented Mar 18, 2024

Problem

I removed the filter variable in #223, but I didn't notice that the non-Unix code was also using it 😞

Summary of Changes

use the new public const in the solana_logger

pub const DEFAULT_FILTER: &str = "solana=info,agave=info";


This is an automatic backport of pull request #245 done by Mergify.

fix: use the correct log filter for non-unix
(cherry picked from commit 2537e3e)
@mergify mergify bot assigned yihau Mar 18, 2024
@yihau yihau requested a review from CriesofCarrots March 18, 2024 05:48
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.6%. Comparing base (af153cb) to head (4326d16).

Additional details and impacted files
@@            Coverage Diff            @@
##            v1.17     #287     +/-   ##
=========================================
- Coverage    81.6%    81.6%   -0.1%     
=========================================
  Files         806      806             
  Lines      219224   219224             
=========================================
- Hits       178989   178922     -67     
- Misses      40235    40302     +67     

@yihau yihau merged commit 4d499a3 into v1.17 Mar 19, 2024
31 checks passed
@yihau yihau deleted the mergify/bp/v1.17/pr-245 branch March 19, 2024 06:20
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants