Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[anza migration] fix: use the correct log filter for non-unix #245

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

yihau
Copy link
Member

@yihau yihau commented Mar 14, 2024

Problem

I removed the filter variable in #223, but I didn't notice that the non-Unix code was also using it 😞

Summary of Changes

use the new public const in the solana_logger

pub const DEFAULT_FILTER: &str = "solana=info,agave=info";

Copy link

@CriesofCarrots CriesofCarrots left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😅

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.9%. Comparing base (51dc7e6) to head (dde48d6).

Additional details and impacted files
@@            Coverage Diff            @@
##           master     #245     +/-   ##
=========================================
- Coverage    81.9%    81.9%   -0.1%     
=========================================
  Files         837      837             
  Lines      226743   226743             
=========================================
- Hits       185776   185716     -60     
- Misses      40967    41027     +60     

@yihau yihau merged commit 2537e3e into anza-xyz:master Mar 15, 2024
33 checks passed
@yihau yihau deleted the fix-windows-build branch March 15, 2024 03:27
Copy link

mergify bot commented Mar 18, 2024

Backports to the stable branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule.

Copy link

mergify bot commented Mar 18, 2024

Backports to the beta branch are to be avoided unless absolutely necessary for fixing bugs, security issues, and perf regressions. Changes intended for backport should be structured such that a minimum effective diff can be committed separately from any refactoring, plumbing, cleanup, etc that are not strictly necessary to achieve the goal. Any of the latter should go only into master and ride the normal stabilization schedule. Exceptions include CI/metrics changes, CLI improvements and documentation updates on a case by case basis.

mergify bot pushed a commit that referenced this pull request Mar 18, 2024
fix: use the correct log filter for non-unix
(cherry picked from commit 2537e3e)
mergify bot pushed a commit that referenced this pull request Mar 18, 2024
fix: use the correct log filter for non-unix
(cherry picked from commit 2537e3e)
yihau added a commit that referenced this pull request Mar 19, 2024
…(backport of #245) (#288)

[anza migration] fix: use the correct log filter for non-unix (#245)

fix: use the correct log filter for non-unix
(cherry picked from commit 2537e3e)

Co-authored-by: Yihau Chen <a122092487@gmail.com>
yihau added a commit that referenced this pull request Mar 19, 2024
…(backport of #245) (#287)

[anza migration] fix: use the correct log filter for non-unix (#245)

fix: use the correct log filter for non-unix
(cherry picked from commit 2537e3e)

Co-authored-by: Yihau Chen <a122092487@gmail.com>
@HaoranYi HaoranYi mentioned this pull request Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants