Feat/check res table #848
Closed
Feat/check res table #848
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #848 +/- ##
==========================================
- Coverage 58.08% 58.02% -0.07%
==========================================
Files 172 172
Lines 10560 10573 +13
==========================================
+ Hits 6134 6135 +1
- Misses 4426 4438 +12 |
akaszynski
reviewed
Jan 21, 2022
|
|
||
|
|
||
| # Function to build main | ||
| def check_res_table(row_names=None, simulation_res=None, target_res=None): |
akaszynski
reviewed
Jan 21, 2022
| # If someone did not identify inputs at all, | ||
| # it represents default data frame example. | ||
| if row_names is None: | ||
| print("No Inputs") |
There was a problem hiding this comment.
Don't print, raise:
raise ValueError('missing row_names')
akaszynski
reviewed
Jan 21, 2022
|
|
||
|
|
||
| # Function to build main | ||
| def check_res_table(row_names=None, simulation_res=None, target_res=None): |
There was a problem hiding this comment.
If these parameters are always required, then should be using arg and not kwarg.
akaszynski
reviewed
Jan 21, 2022
| if len(row_names) != len(target_res) or len(row_names) != len(target_res): | ||
| raise TypeError("Not the same quantity of the rows and filled data") | ||
|
|
||
| # Import Pandas and Numpy. |
There was a problem hiding this comment.
Move to top, specify why you're doing a lazy import.
|
Recommending abandoning this due to changes in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR takes into account the necessity to create a data frame for printing output results on the VMs using Pandas.
It takes in account issue: #846