-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Verification Manual VM8 #820
Conversation
Codecov Report
@@ Coverage Diff @@
## main #820 +/- ##
=======================================
Coverage 57.58% 57.58%
=======================================
Files 172 172
Lines 10559 10559
=======================================
Hits 6080 6080
Misses 4479 4479 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor suggestions, mainly regarding format.
df2.style.set_table_styles([ | ||
{ | ||
"selector": "th", | ||
"props": [('font-size', '16px')] | ||
}, | ||
{ | ||
"selector": "td", | ||
"props": [('font-size', '16px')] | ||
}, | ||
{ | ||
"selector": "td:hover", | ||
"props": [("background-color", "#FFF8DC")] | ||
}]).set_properties(** | ||
{ | ||
"color": "black", | ||
"text-align": "center" | ||
}).format("{:.2f}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
df2.style.set_table_styles([ | |
{ | |
"selector": "th", | |
"props": [('font-size', '16px')] | |
}, | |
{ | |
"selector": "td", | |
"props": [('font-size', '16px')] | |
}, | |
{ | |
"selector": "td:hover", | |
"props": [("background-color", "#FFF8DC")] | |
}]).set_properties(** | |
{ | |
"color": "black", | |
"text-align": "center" | |
}).format("{:.2f}") | |
df2.style |
You could just use this, and the output is similar:
But smaller font size.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really think this block of code is not needed.
Please do not include any style in the dataframe, I believe we are better moving towards a theme definition of the table style. Therefore, after getting the pandas dataframe, just call # Create and fill the output dataframe with pandas.
df2 = pd.DataFrame(main_columns, index=row_names)
# Apply style settings for the dataframe.
df2.style It should look like: Please check: |
Thank u German for your feedback! About data frame code I will finish PR of VM10 during a few hours, and I'll be back to check all your suggestions and apply them. Thank you again for your feedback! |
df2.style.set_table_styles([ | ||
{ | ||
"selector": "th", | ||
"props": [('font-size', '16px')] | ||
}, | ||
{ | ||
"selector": "td", | ||
"props": [('font-size', '16px')] | ||
}, | ||
{ | ||
"selector": "td:hover", | ||
"props": [("background-color", "#FFF8DC")] | ||
}]).set_properties(** | ||
{ | ||
"color": "black", | ||
"text-align": "center" | ||
}).format("{:.2f}") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really think this block of code is not needed.
You haven't addressed (almost) any of the changes I proposed you. Hiding the |
Hi @germa89, As we have discussed, yesterday, I would like to summarize the work done:
Thank you in advance! |
Hi @germa89 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Thank you!
This PR adds VM8, with good step by step explanations, how to provide full simulation of
the Parametric Calculation of Point-to-Point Distances.
VM8:
1st commit: code almost done with idea how to modify
mapdl.ndist
at the main script