Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing edit button fix #2341

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Removing edit button fix #2341

merged 6 commits into from
Sep 28, 2023

Conversation

germa89
Copy link
Collaborator

@germa89 germa89 commented Sep 18, 2023

It should remove redundancy in code.

Close #2254

@germa89
Copy link
Collaborator Author

germa89 commented Sep 18, 2023

I'm highly skeptical of this honestly

@germa89 germa89 requested review from RobPasMue, Revathyvenugopal162 and jorgepiloto and removed request for RobPasMue September 18, 2023 11:33
@germa89 germa89 self-assigned this Sep 18, 2023
@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Merging #2341 (483e83d) into main (d9e48f4) will decrease coverage by 0.25%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #2341      +/-   ##
==========================================
- Coverage   87.67%   87.42%   -0.25%     
==========================================
  Files          45       44       -1     
  Lines        8527     8455      -72     
==========================================
- Hits         7476     7392      -84     
- Misses       1051     1063      +12     

@germa89
Copy link
Collaborator Author

germa89 commented Sep 19, 2023

Waiting for a new release of ansys-sphinx-theme. @Revathyvenugopal162

@germa89
Copy link
Collaborator Author

germa89 commented Sep 27, 2023

I'm going to merge "blindly" because I cannot check without it getting online I guess????.....

@germa89
Copy link
Collaborator Author

germa89 commented Sep 27, 2023

I'm going to merge "blindly" because I cannot check without it getting online I guess????.....

@Revathyvenugopal162 you ok with that?

@germa89 germa89 merged commit d7fa8ec into main Sep 28, 2023
27 checks passed
@germa89 germa89 deleted the doc/remove-edit-button-bits branch September 28, 2023 13:31
@germa89
Copy link
Collaborator Author

germa89 commented Sep 29, 2023

It seems to work ok.

I am checking the changes. For example this link:

node — PyMAPDL (pyansys.com)

  • The edit on Github button takes you to the right file, but at the very top. Not to the right function. But it opens the editor.

  • The [Source] button takes you to the right function/class definition. So I would say it is more precise. But it just on "view mode" not editor.

I see a bit of redundancy, but I would probably keep both. However I would expect that the editor mode will take you to the right lines. But maybe it is not possible.

@germa89
Copy link
Collaborator Author

germa89 commented Sep 29, 2023

The source is fully on our control, so we could go to precise file, but edit this button is just a modification on pydata-sphinx-theme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider remove the edit_link_code bits
2 participants