Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: try except to handle value error for linkcode extension #297

Merged
merged 1 commit into from
Sep 18, 2023
Merged

fix: try except to handle value error for linkcode extension #297

merged 1 commit into from
Sep 18, 2023

Conversation

Revathyvenugopal162
Copy link
Contributor

@Revathyvenugopal162 Revathyvenugopal162 commented Sep 18, 2023 •
edited
Loading

ansys/pymapdl#2341 fixes the value error

@Revathyvenugopal162 Revathyvenugopal162 requested a review from a team as a code owner September 18, 2023 15:49
@github-actions github-actions bot added the bug Defects or glitches reported by users or developers label Sep 18, 2023
germa89
germa89 approved these changes Sep 18, 2023
View reviewed changes
Copy link
Contributor

@germa89 germa89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont really understand how this works.. but I trust you

@Revathyvenugopal162 Revathyvenugopal162 merged commit d9fe77c into main Sep 18, 2023
21 checks passed
@Revathyvenugopal162 Revathyvenugopal162 deleted the fix/exetension-error branch September 18, 2023 16:03
@germa89
Copy link
Contributor

germa89 commented Sep 19, 2023

I checked and it seems to work locally in PyMAPDL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germa89 germa89 germa89 approved these changes

Assignees
No one assigned
Labels
bug Defects or glitches reported by users or developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Revathyvenugopal162 @germa89