Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wip/test fix side bar #334

Closed
wants to merge 3 commits into from
Closed

Wip/test fix side bar #334

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c3277ee
WIP: test main of pydata-sphinx-theme
SMoraisAnsys Jan 11, 2024
a4be3ad
WIP: apply side_bar changes
SMoraisAnsys Jan 11, 2024
90c7c7a
Merge branch 'main' into wip/test_fix_side_bar
Revathyvenugopal162 Jan 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ classifiers = [
]
dependencies = [
"Sphinx>=4.2.0",
"pydata-sphinx-theme>=0.14.0",
"pydata-sphinx-theme@git+https://github.com/pydata/pydata-sphinx-theme#egg=main",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue with this is that using a branch does not allow to upload a new version to PyPI.

We need to limit the upper version for the pydata-sphinx-theme.

# "pydata-sphinx-theme>=0.14.0",
Comment on lines +29 to +30
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"pydata-sphinx-theme@git+https://github.com/pydata/pydata-sphinx-theme#egg=main",
# "pydata-sphinx-theme>=0.14.0",
"pydata-sphinx-theme>0.14,<0.15",

"Jinja2>=3.1.2",
"importlib-metadata>=4.0",
]
Expand Down
2 changes: 1 addition & 1 deletion src/ansys_sphinx_theme/theme/ansys_sphinx_theme/search.html
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's discard these changes.

Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@
<div class="bd-container__inner bd-page-width">
{# Primary sidebar #} {# If we have no sidebar TOC, pop the TOC component
from the sidebar list #} {% if
get_sidebar_toctree_length(show_nav_level=theme_show_nav_level|int) == 0 %}
missing_sidebar_toctree(show_nav_level=theme_show_nav_level | int) == 0 %}
{% set sidebars = sidebars | reject("in", "sidebar-nav-bs.html") | list %}
{% endif %}
<div
Expand Down