Wip/test fix side bar #334
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
maintenance
jorgepiloto
requested changes
Jan 12, 2024
| @@ -26,7 +26,8 @@ classifiers = [ | |||
| ] | |||
| dependencies = [ | |||
| "Sphinx>=4.2.0", | |||
| "pydata-sphinx-theme>=0.14.0", | |||
| "pydata-sphinx-theme@git+https://github.com/pydata/pydata-sphinx-theme#egg=main", | |||
There was a problem hiding this comment.
The issue with this is that using a branch does not allow to upload a new version to PyPI.
We need to limit the upper version for the pydata-sphinx-theme.
|
I think the latest version to work for us was |
jorgepiloto
requested changes
Jan 12, 2024
There was a problem hiding this comment.
Let's discard these changes.
Comment on lines
+29
to
+30
| "pydata-sphinx-theme@git+https://github.com/pydata/pydata-sphinx-theme#egg=main", | ||
| # "pydata-sphinx-theme>=0.14.0", |
There was a problem hiding this comment.
Suggested change
| "pydata-sphinx-theme@git+https://github.com/pydata/pydata-sphinx-theme#egg=main", | |
| # "pydata-sphinx-theme>=0.14.0", | |
| "pydata-sphinx-theme>0.14,<0.15", |
|
Dependabot should be the one opening a new PR every time there is a new major release for the pydata-sphinx-theme. If so, we should review in depth the rendering of this new version. |
|
Closing this PR but keeping the branch alive ftm. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As it stands, the associated branch performs a change to be able to use the current main branch of https://github.com/pydata/pydata-sphinx-theme The idea here is to be able to use the fix that has been merged in
pydata/pydata-sphinx-theme#1632 to fix the problem of side bare when using option :hidden:.
I've been able to validate this change through ansys/pyedb#111