Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethinking code style #18

Merged
merged 3 commits into from
Jan 24, 2022
Merged

Rethinking code style #18

merged 3 commits into from
Jan 24, 2022

Conversation

germa89
Copy link
Contributor

@germa89 germa89 commented Jan 24, 2022

I'm not super happy about the readability of the text rendered as code:

image

And some people (@RomanIlchenko1308 ) have already pointed out that the size looks smaller than the rest of the body text.

Quick fix is to increase the font-size a bit (to 15.5px) so we can improve readability and visual impact.

image

However, I'm partial to change the font altogether. I personally like Roboto condensed Light [Link] (size: normal (15px))(https://fonts.google.com/specimen/Roboto+Condensed?preview.text=package,%20ansys-mapdl-core,%20pro&preview.text_type=custom):

image

Or even better consolas (size: normal (15px)):

image

@germa89
Copy link
Contributor Author

germa89 commented Jan 24, 2022

I acknowledge that half pixels will just be rounded, but it has some effects in some cases (zoom).

Link: https://stackoverflow.com/a/22832095/6650211

@germa89 germa89 self-assigned this Jan 24, 2022
@germa89 germa89 added documentation enhancement General improvements to existing features labels Jan 24, 2022
@Andy-Grigg
Copy link
Contributor

consolas is a great choice, and is my go-to font when I'm formatting monospace code in emails, Word, etc. But I think the issue will be cross-platform availability; consolas is a Microsoft-owned font and generally isn't available on non-Windows machines.

Inconsolata might be a good option, it's inspired by consolas, and is available for free on google fonts here, which is great, because that means we can include it in the CSS as a web font.

Font availability is always a bit of a pain. I really like cascadia-code, but whilst it's an open source font, there's currently no official webfont support.

@germa89
Copy link
Contributor Author

germa89 commented Jan 24, 2022

Using Inconsolata together with @import and font-size 15.5px.

image

Copy link
Contributor

@Andy-Grigg Andy-Grigg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New font looks nice!

@akaszynski akaszynski merged commit 39af76c into main Jan 24, 2022
@akaszynski akaszynski deleted the feat/-Increase-the-code-font branch January 24, 2022 18:30
@akaszynski akaszynski mentioned this pull request Feb 16, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General improvements to existing features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants