Add job settings form and unit tests #8661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marshmalien
added
state:needs_review
type:feature
|
Build succeeded.
|
|
Build succeeded.
|
|
Will only require manual testing and re-enabling of TBI stubs |
|
Not a requirement, but this would be a great time to tackle this https://github.com/ansible/tower-qa/issues/5813 to get some global state tests online |
marshmalien
force-pushed
the
setting-jobs-ui
branch
from
a0b0cdf
to
88a321a
Compare
|
Build succeeded.
|
marshmalien
force-pushed
the
setting-jobs-ui
branch
from
88a321a
to
adc50c3
Compare
|
Build succeeded.
|
|
@marshmalien it looks like the order of fields is different between edit page and detail page |
marshmalien
force-pushed
the
setting-jobs-ui
branch
from
adc50c3
to
a9107ae
Compare
|
Build succeeded.
|
marshmalien
force-pushed
the
setting-jobs-ui
branch
from
a9107ae
to
8a58a73
Compare
|
Build succeeded.
|
tiagodread
approved these changes
Jan 29, 2021
There was a problem hiding this comment.
Nice, it worked as expected updated some test here https://github.com/ansible/tower-qa/pull/5918
|
Build succeeded (gate pipeline).
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Issue: #8290
This PR adds the job category settings form.
ISSUE TYPE
COMPONENT NAME