Handle reverting falsy values that are not null or undefined

ansible · Jan 29, 2021 · 8a58a73 · 8a58a73
1 parent db4d84b
commit 8a58a73
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/awx/ui_next/src/screens/Setting/shared/SharedFields.jsx b/awx/ui_next/src/screens/Setting/shared/SharedFields.jsx
@@ -195,7 +195,7 @@ const InputField = withI18n()(
 
     return config ? (
       <SettingGroup
-        defaultValue={config.default || ''}
+        defaultValue={config.default ?? ''}
         fieldId={name}
         helperTextInvalid={meta.error}
         isRequired={isRequired}

diff --git a/awx/ui_next/src/screens/Setting/shared/SharedFields.test.jsx b/awx/ui_next/src/screens/Setting/shared/SharedFields.test.jsx
@@ -133,6 +133,35 @@ describe('Setting form fields', () => {
     expect(wrapper.find('TextInputBase').prop('value')).toEqual('foo');
   });
 
+  test('InputField should revert to expected default value', async () => {
+    const wrapper = mountWithContexts(
+      <Formik
+        initialValues={{
+          number: 5,
+        }}
+      >
+        {() => (
+          <InputField
+            name="number"
+            type="number"
+            config={{
+              label: 'test number input',
+              min_value: -10,
+              default: 0,
+            }}
+          />
+        )}
+      </Formik>
+    );
+    expect(wrapper.find('TextInputBase')).toHaveLength(1);
+    expect(wrapper.find('TextInputBase').prop('value')).toEqual(5);
+    await act(async () => {
+      wrapper.find('button[aria-label="Revert"]').invoke('onClick')();
+    });
+    wrapper.update();
+    expect(wrapper.find('TextInputBase').prop('value')).toEqual(0);
+  });
+
   test('TextAreaField renders the expected content', async () => {
     const wrapper = mountWithContexts(
       <Formik