Add feature to edit instance group #7864
Conversation
|
Build succeeded.
|
| type="text" | ||
| validate={required(null, i18n)} | ||
| isRequired | ||
| isDisabled={instanceGroupNameField.value === 'tower'} |
There was a problem hiding this comment.
In addition to the validation ranges you've provided, please add a min & max value for the inputs - They're supported and improve the UX when setting these values with a mouse wheel or keyboard arrows:
There was a problem hiding this comment.
Thanks for your review @jakemcdermott. Updating now.
| @@ -1,6 +1,6 @@ | |||
| import React from 'react'; | |||
There was a problem hiding this comment.
@nixocio Since IGs don't have an add subscreen, this component isn't actually shared. I think we should move this file to InstanceGroup/InstanceGroupEdit and delete the shared folder (for now, that is. Container Groups may actually have a shared form but I presume you'll do that in a different PR)
There was a problem hiding this comment.
InstanceGroupForm is shared between the InstanceGroupAdd and InstanceGroupEdit even in this case, is your suggestion still valid? I was trying to follow the same pattern that already in code basis. But it seems to be valid just in cases we have a shared subscreen. I will evaluate this change.
There was a problem hiding this comment.
@nixocio Whoops, you're right. IGs do have an add form. Never mind! It is fine as is.
Add feature to edit instance group. See: ansible#7767
|
Build succeeded.
|
|
Build succeeded (gate pipeline).
|
Add feature to edit instance group.
See: #7767